* Re: [PATCH 2/2] s390: qeth: Avoid unneeded command name lookup
[not found] <65861df5-afbe-e8b4-ea6e-37c12d6c2301@linux.ibm.com>
@ 2018-09-12 14:59 ` Jean Delvare
0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2018-09-12 14:59 UTC (permalink / raw)
To: linux-s390
Hi Julian,
On Wed, 2018-09-12 at 16:50 +0200, Julian Wiedmann wrote:
> Thanks Jean, but I'd rather pass on this one. I don't see an improvement
> in readability, and performance just isn't a concern for this specific
> path... there's hardly any traffic on the interface's control plane.
Sure, you will know better. The initial optimization of
qeth_get_ipa_msg() and qeth_get_ipa_cmd_name() made me wonder if maybe
performance was considered important on these paths, and this is why I
wanted to pay attention that my changes would not cause a performance
regression. If there is no such concern then all is well and this
second patch is indeed not needed.
Thanks,
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-09-12 14:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <65861df5-afbe-e8b4-ea6e-37c12d6c2301@linux.ibm.com>
2018-09-12 14:59 ` [PATCH 2/2] s390: qeth: Avoid unneeded command name lookup Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).