Re: [kvm-unit-tests PATCH v1 3/5] s390x: sclp: expose ram_size and max_ram_size

David Hildenbrand
2019-10-22T15:44:56Z

On 22.10.19 14:16, Thomas Huth wrote:
> On 22/10/2019 12.53, Claudio Imbrenda wrote:
>> Expose ram_size and max_ram_size through accessor functions.
>>
>> We only use get_ram_size in an upcoming patch, but having an accessor
>> for the other one does not hurt.
>>
>> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> lib/s390x/sclp.h | 2 ++
>> lib/s390x/sclp.c | 9 +++++++++
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h
>> index f00c3df..6d40fb7 100644
>> --- a/lib/s390x/sclp.h
>> +++ b/lib/s390x/sclp.h
>> @@ -272,5 +272,7 @@ void sclp_console_setup(void);
>> void sclp_print(const char *str);
>> int sclp_service_call(unsigned int command, void *sccb);
>> void sclp_memory_setup(void);
>> +uint64_t get_ram_size(void);
>> +uint64_t get_max_ram_size(void);
>>
>> #endif /* SCLP_H */
>> diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c
>> index 56fca0c..a57096c 100644
>> --- a/lib/s390x/sclp.c
>> +++ b/lib/s390x/sclp.c
>> @@ -167,3 +167,12 @@ void sclp_memory_setup(void)
>>
>> mem_init(ram_size);
>> }
>> +
>> +uint64_t get_ram_size(void)
>> +{
>> + return ram_size;
>> +}
>> +uint64_t get_max_ram_size(void)
>> +{
>> + return max_ram_size;
>> +}
>
> In case you respin, please add an empty line between the two functions.
>

Indeed

Reviewed-by: David Hildenbrand <david@redhat.com>

> Reviewed-by: Thomas Huth <thuth@redhat.com>
>

--

Thanks,

David / dhildenb