Re: [kvm-unit-tests PATCH v1 2/5] s390x: improve error reporting for interrupts

Thomas Huth
2019-10-22T11:56:24Z

On 22/10/2019 12.53, Claudio Imbrenda wrote:
> Improve error reporting for unexpected external interrupts to also
> print the received external interrupt code.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> lib/s390x/interrupt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c
> index 5cade23..1636207 100644
> --- a/lib/s390x/interrupt.c
> +++ b/lib/s390x/interrupt.c
> @@ -118,8 +118,8 @@ void handle_ext_int(void)
> {
> if (!ext_int_expected &&
> lc->ext_int_code != EXT_IRQ_SERVICE_SIG) {
> - report_abort("Unexpected external call interrupt: at %#lx",
> - lc->ext_old_psw.addr);
> + report_abort("Unexpected external call interrupt (code %#x): at %#lx",
> + lc->ext_int_code, lc->ext_old_psw.addr);
> return;
> }
>
>

Reviewed-by: Thomas Huth <thuth@redhat.com>