Re: [PATCH -next] writeback: fix -Wformat compilation warnings

Tejun Heo
2019-11-14T19:21:21Z

On Thu, Nov 14, 2019 at 12:17:41PM -0500, Qian Cai wrote:
> The commit f05499a06fb4 ("writeback: use ino_t for inodes in
> tracepoints") introduced a lot of GCC compilation warnings on s390,
>
> In file included from ./include/trace/define_trace.h:102,
> from ./include/trace/events/writeback.h:904,
> from fs/fs-writeback.c:82:
> ./include/trace/events/writeback.h: In function
> 'trace_raw_output_writeback_page_template':
> ./include/trace/events/writeback.h:76:12: warning: format '%lu' expects
> argument of type 'long unsigned int', but argument 4 has type 'ino_t'
> {aka 'unsigned int'} [-Wformat=]
> TP_printk("bdi %s: ino=%lu index=%lu",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./include/trace/trace_events.h:360:22: note: in definition of macro
> 'DECLARE_EVENT_CLASS'
> trace_seq_printf(s, print); \
> ^~~~~
> ./include/trace/events/writeback.h:76:2: note: in expansion of macro
> 'TP_printk'
> TP_printk("bdi %s: ino=%lu index=%lu",
> ^~~~~~~~~
>
> Fix them by adding necessary casts where ino_t could be either "unsigned
> int" or "unsigned long".
>
> Fixes: f05499a06fb4 ("writeback: use ino_t for inodes in tracepoints")
> Signed-off-by: Qian Cai <cai@lca.pw>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun