Re: [kvm-unit-tests PATCH v5 03/10] s390x: cr0: adding AFP-register control bit

Janosch Frank
2020-04-22T07:39:11Z

[-- Attachment #1.1: Type: text/plain, Size: 1897 bytes --]

On 2/20/20 1:00 PM, Pierre Morel wrote:
> While adding the definition for the AFP-Register control bit, move all
> existing definitions for CR0 out of the C zone to the assmbler zone to
> keep the definitions concerning CR0 together.

How about:
s390x: Move control register bit definitions and add AFP to them

Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> lib/s390x/asm/arch_def.h | 11 ++++++-----
> s390x/cstart64.S | 2 +-
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
> index 69a8256..863c2bf 100644
> --- a/lib/s390x/asm/arch_def.h
> +++ b/lib/s390x/asm/arch_def.h
> @@ -18,6 +18,12 @@
>
> #define PSW_EXCEPTION_MASK (PSW_MASK_EA|PSW_MASK_BA)
>
> +#define CR0_EXTM_SCLP 0X0000000000000200UL
> +#define CR0_EXTM_EXTC 0X0000000000002000UL
> +#define CR0_EXTM_EMGC 0X0000000000004000UL
> +#define CR0_EXTM_MASK 0X0000000000006200UL
> +#define CR0_AFP_REG_CRTL 0x0000000000040000UL
> +
> #ifndef __ASSEMBLER__
>
> struct psw {
> @@ -25,11 +31,6 @@ struct psw {
> uint64_t addr;
> };
>
> -#define CR0_EXTM_SCLP 0X0000000000000200UL
> -#define CR0_EXTM_EXTC 0X0000000000002000UL
> -#define CR0_EXTM_EMGC 0X0000000000004000UL
> -#define CR0_EXTM_MASK 0X0000000000006200UL
> -
> struct lowcore {
> uint8_t pad_0x0000[0x0080 - 0x0000]; /* 0x0000 */
> uint32_t ext_int_param; /* 0x0080 */
> diff --git a/s390x/cstart64.S b/s390x/cstart64.S
> index 2885a36..3b59bd1 100644
> --- a/s390x/cstart64.S
> +++ b/s390x/cstart64.S
> @@ -230,4 +230,4 @@ svc_int_psw:
> .quad PSW_EXCEPTION_MASK, svc_int
> initial_cr0:
> /* enable AFP-register control, so FP regs (+BFP instr) can be used */
> - .quad 0x0000000000040000
> + .quad CR0_AFP_REG_CRTL
>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]