Re: [kvm-unit-tests PATCH v6 06/10] s390x: css: stsch, enumeration test

Pierre Morel
2020-05-15T07:05:16Z

On 2020-05-14 14:05, Cornelia Huck wrote:
> On Fri, 24 Apr 2020 12:45:48 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> First step for testing the channel subsystem is to enumerate the css and
>> retrieve the css devices.
>>
>> This tests the success of STSCH I/O instruction, we do not test the
>
> s/of/of the/

Yes, zhanks.

>
>> reaction of the VM for an instruction with wrong parameters.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>> lib/s390x/css.h | 1 +
>> s390x/Makefile | 2 +
>> s390x/css.c | 92 +++++++++++++++++++++++++++++++++++++++++++++
>> s390x/unittests.cfg | 4 ++
>> 4 files changed, 99 insertions(+)
>> create mode 100644 s390x/css.c
>>
>
> (...)
>
>> +static void test_enumerate(void)
>> +{
>> + struct pmcw *pmcw = &schib.pmcw;
...snip...
goto out;
>> + default: /* 1 or 2 should never happened for STSCH */
>
> s/happened/happen/

Yes, thanks.

>
>> + report(0, "Unexpected cc=%d on subchannel number 0x%x",
>> + cc, scn);
>> + return;
>> + }
>

Thanks,

Regards,
Pierre

--
Pierre Morel
IBM Lab Boeblingen