Re: [kvm-unit-tests PATCH v12 9/9] s390x: css: ssch/tsch with sense and interrupt

Pierre Morel
2020-07-15T10:49:37Z

On 2020-07-15 12:15, Cornelia Huck wrote:
> On Tue, 14 Jul 2020 13:15:48 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> After a channel is enabled we start a SENSE_ID command using
>> the SSCH instruction to recognize the control unit and device.
>>
>> This tests the success of SSCH, the I/O interruption and the TSCH
>> instructions.
>>
>> The SENSE_ID command response is tested to report 0xff inside
>> its reserved field and to report the same control unit type
>> as the cu_type kernel argument.
>>
>> Without the cu_type kernel argument, the test expects a device
>> with a default control unit type of 0x3832, a.k.a virtio-net-ccw.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>> lib/s390x/asm/arch_def.h | 1 +
>> lib/s390x/css.h | 35 ++++++++
>> lib/s390x/css_lib.c | 180 +++++++++++++++++++++++++++++++++++++++
>> s390x/css.c | 80 +++++++++++++++++
>> 4 files changed, 296 insertions(+)
>
> Other than the padding issue, looks good to me now.
>

Thanks, so one last respin. :)

--
Pierre Morel
IBM Lab Boeblingen