Re: [PATCH kvm-unit-tests v1 4/6] s390x: smp: Create and use a non-waiting CPU stop

Eric Farman
2022-03-07T19:01:17Z

On Mon, 2022-03-07 at 14:31 +0100, Nico Boehr wrote:
> On Thu, 2022-03-03 at 22:04 +0100, Eric Farman wrote:
> [...]
>
> > --- a/s390x/smp.c
> > +++ b/s390x/smp.c
> > @@ -76,14 +76,8 @@ static void test_restart(void)
> >
> > static void test_stop(void)
> > {
> > - smp_cpu_stop(1);
> > - /*
> > - * The smp library waits for the CPU to shut down, but
> > let's
> > - * also do it here, so we don't rely on the library
> > - * implementation
> > - */
> > - while (!smp_cpu_stopped(1)) {}
> > - report_pass("stop");
> > + smp_cpu_stop_nowait(1);
>
> Now that this can fail because of CC=2, should we check the return
> value here?

Ah, yes it should. Thanks,

Eric