Re: [kvm-unit-tests PATCH v2 1/5] s390x: css: Store CSS Characteristics

Pierre Morel
2021-02-12T15:37:17Z

On 2/12/21 11:32 AM, Cornelia Huck wrote:
> On Wed, 10 Feb 2021 14:20:10 +0100
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> CSS characteristics exposes the features of the Channel SubSystem.
>> Let's use Store Channel Subsystem Characteristics to retrieve
>> the features of the CSS.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>> lib/s390x/css.h | 69 +++++++++++++++++++++++++++
>> lib/s390x/css_lib.c | 112 +++++++++++++++++++++++++++++++++++++++++++-
>> s390x/css.c | 12 +++++
>> 3 files changed, 192 insertions(+), 1 deletion(-)
>>
>
> (...)
>
>> +static const char *chsc_rsp_description[] = {
>> + "CHSC unknown error",
>> + "Command executed",
>> + "Invalid command",
>> + "Request-block error",
>> + "Command not installed",
>> + "Data not available",
>> + "Absolute address of channel-subsystem"
>> + "communication block exceeds 2 - 1.",
>
> "2G - 1", I think?

:) yes

>
>> + "Invalid command format",
>> + "Invalid channel-subsystem identification (CSSID)",
>> + "The command-request block specified an invalid format"
>> + "for the command response block.",
>> + "Invalid subchannel-set identification (SSID)",
>> + "A busy condition precludes execution.",
>> +};
>
> (...)
>
> This matches both the Linux implementation and my memories, so
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>

Thanks,
Pierre

--
Pierre Morel
IBM Lab Boeblingen