Re: [kvm-unit-tests PATCH v2 2/5] s390x: css: simplifications of the tests

Pierre Morel
2021-02-12T15:37:58Z

On 2/12/21 11:36 AM, Cornelia Huck wrote:
> On Wed, 10 Feb 2021 14:20:11 +0100
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> In order to ease the writing of tests based on:
>> - interrupt
>> - enabling a subchannel
>> - using multiple I/O on a channel without disabling it
>>
>> We do the following simplifications:
>> - the I/O interrupt handler is registered on CSS initialization
>> - We do not enable again a subchannel in senseid if it is already
>> enabled
>> - we add a css_enabled() function to test if a subchannel is enabled
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>> lib/s390x/css.h | 1 +
>> lib/s390x/css_lib.c | 37 ++++++++++++++++++++++----------
>> s390x/css.c | 51 ++++++++++++++++++++++++++-------------------
>> 3 files changed, 56 insertions(+), 33 deletions(-)
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>

Thanks,
Pierre

--
Pierre Morel
IBM Lab Boeblingen