From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C290FC433F5 for ; Tue, 3 May 2022 16:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239652AbiECQmp (ORCPT ); Tue, 3 May 2022 12:42:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235042AbiECQmo (ORCPT ); Tue, 3 May 2022 12:42:44 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D11EC27B28 for ; Tue, 3 May 2022 09:39:10 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id t11-20020a17090ad50b00b001d95bf21996so2767840pju.2 for ; Tue, 03 May 2022 09:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=s39mE0kiqCYA7ZYSMO88r6nrLoSeKkE/K4dp3BvGwGs=; b=pGDpCf7sl1d7573gjTTpqwkm3SiLycRrYLR/Cpm0xghxjpDf3AYMtstNaQt6JhXwCj hQ35tsdAS9xUuNcQ6bjTAIO4jrWGURYFn6WniUxLx9leI8Us/ZQXxmUsx5sXqR+3SMFs NPtnD8cP+Vrfqw+JIy3zA370Pyvn+VSXvM3gc7wLfoXTetostms9mgjy7Euc3hVJAm4j a9n45bGAUG8eOYOtc2pRDLYRKouGSmmTKZVBKYAG6yGnvzNVe7ulVhqBTMV0jNCtQJ1b eh8fwFdSJCS0763Fc+Es4Igf8he/A1M8/7QNTfbxn1mM2JdiBuUfp0c3rzGlnMqDUeCY VcJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=s39mE0kiqCYA7ZYSMO88r6nrLoSeKkE/K4dp3BvGwGs=; b=lnRnv2OkAh7Es3jTzlxaSWu/g716N13VuYep0a+nAOWxW4d/u2KJVcD35jvMGVkQbW dr3YIXwqWnhqmsBfaksvHram6JYwvdmfNE5l2r3WeNkphdfmNaMIaGVxMAGKWPNjt/4I PcoAVRGrRwx6TzT5zMee3QGu7ebBSrnbFOq9o6yqPGBGWrtbvDmpRbX3a25s2aElBiAk dxz82jWn164Fz/O0GCK+v6BMVY1tBm9Rq9Q7DI8813bPzkucedkrq6EuMSI/Wy8PMJ22 Q4+x2kO0bEml0gy5uLOXhg31PCY8kX8Mv3VfBewFdszTSsyuxicfByu1QpMfAPmcAJQz 9rFw== X-Gm-Message-State: AOAM531M96So3Omk7uM5g/rVQEIAkkawEe3eg734N3OeEStU6Td+n4Tp Uf8NWrT8mK/TsOzOeoKqIZ7L5A== X-Google-Smtp-Source: ABdhPJynf+YKk08yAhS/p4BXstboFDeyZsD4FTBMM24xr+KLv+BRsvUdLzF1UAPk9hKAVzsu2Q8whQ== X-Received: by 2002:a17:90a:9901:b0:1cb:aa19:5eee with SMTP id b1-20020a17090a990100b001cbaa195eeemr5645991pjp.158.1651595950265; Tue, 03 May 2022 09:39:10 -0700 (PDT) Received: from [127.0.1.1] ([8.34.116.185]) by smtp.gmail.com with ESMTPSA id m9-20020a17090a858900b001d9b7fa9562sm1559200pjn.28.2022.05.03.09.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 09:39:09 -0700 (PDT) From: Jens Axboe To: Christoph Hellwig Cc: mst@redhat.com, linux-s390@vger.kernel.org, sth@linux.ibm.com, martin.petersen@oracle.com, dm-devel@redhat.com, hoeppner@linux.ibm.com, linux-nvme@lists.infradead.org, richard@nod.at, josef@toxicpanda.com, virtualization@lists.linux-foundation.org, snitzer@kernel.org, roger.pau@citrix.com, linux-um@lists.infradead.org, linux-block@vger.kernel.org, song@kernel.org, nbd@other.debian.org, linux-raid@vger.kernel.org, johannes@sipsolutions.net, haris.iqbal@ionos.com, xen-devel@lists.xenproject.org, jasowang@redhat.com, jinpu.wang@ionos.com In-Reply-To: <20220418045314.360785-1-hch@lst.de> References: <20220418045314.360785-1-hch@lst.de> Subject: Re: fix and cleanup discard_alignment handling Message-Id: <165159594780.2557.1712299203175316151.b4-ty@kernel.dk> Date: Tue, 03 May 2022 10:39:07 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Mon, 18 Apr 2022 06:53:03 +0200, Christoph Hellwig wrote: > the somewhat confusing name of the discard_alignment queue limit, that > really is an offset for the discard granularity mislead a lot of driver > authors to set it to an incorrect value. This series tries to fix up > all these cases. > > Diffstat: > arch/um/drivers/ubd_kern.c | 1 - > drivers/block/loop.c | 1 - > drivers/block/nbd.c | 3 --- > drivers/block/null_blk/main.c | 1 - > drivers/block/rnbd/rnbd-srv-dev.h | 2 +- > drivers/block/virtio_blk.c | 7 ++++--- > drivers/block/xen-blkback/xenbus.c | 4 ++-- > drivers/md/dm-zoned-target.c | 2 +- > drivers/md/raid5.c | 1 - > drivers/nvme/host/core.c | 1 - > drivers/s390/block/dasd_fba.c | 1 - > 11 files changed, 8 insertions(+), 16 deletions(-) > > [...] Applied, thanks! [01/11] ubd: don't set the discard_alignment queue limit commit: 07c6e92a8478770a7302f7dde72f03a5465901bd [02/11] nbd: don't set the discard_alignment queue limit commit: 4a04d517c56e0616c6f69afc226ee2691e543712 [03/11] null_blk: don't set the discard_alignment queue limit commit: fb749a87f4536d2fa86ea135ae4eff1072903438 [04/11] virtio_blk: fix the discard_granularity and discard_alignment queue limits commit: 62952cc5bccd89b76d710de1d0b43244af0f2903 [05/11] dm-zoned: don't set the discard_alignment queue limit commit: 44d583702f4429763c558624fac763650a1f05bf [06/11] raid5: don't set the discard_alignment queue limit commit: 3d50d368c92ade2f98a3d0d28b842a57c35284e9 [07/11] dasd: don't set the discard_alignment queue limit commit: c3f765299632727fa5ea5a0acf118665227a4f1a [08/11] loop: remove a spurious clear of discard_alignment commit: 4418bfd8fb9602d9cd8747c3ad52fdbaa02e2ffd [09/11] nvme: remove a spurious clear of discard_alignment commit: 4e7f0ece41e1be8f876f320a0972a715daec0a50 [10/11] rnbd-srv: use bdev_discard_alignment commit: 18292faa89d2bff3bdd33ab9c065f45fb6710e47 [11/11] xen-blkback: use bdev_discard_alignment commit: c899b23533866910c90ef4386b501af50270d320 Best regards, -- Jens Axboe