Re: [PATCH 1/5] scsi: core: Remove reserved request time-out handling

John Garry
2022-06-20T07:37:35Z

On 20/06/2022 06:58, Christoph Hellwig wrote:
> On Fri, Jun 17, 2022 at 06:55:16PM +0800, John Garry wrote:
>> The SCSI code does not currently support reserved commands. As such,
>> requests which time-out would never be reserved, and scsi_timeout()
>> 'reserved' arg should never be set.
>>
>> Remove handling for reserved requests and drop wrapper scsi_timeout() as
>> it now just calls scsi_times_out() always.
>
> Please rename scsi_times_out to scsi_timeout so it still matches the
> method name.
>

ok, note that some code comments and Documentation reference
scsi_times_out() so I will need to fix them up also.

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> .

Cheers,
John