From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D37345490D; Tue, 5 Mar 2024 11:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.119 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709638619; cv=none; b=lcB4Tm73TIs0VJ6fvkQDsBWKqVTdaLS4+cqtxt82U8mLRDbyfPTXgXkL571mkJOOBVsIhNVgKzRJxShDL8mvtBiVVTcWb0LUYtIfjIyoEweS2w3B+Ph5jJOU1uPR/uUQdD9EWvPKX+i0SP4pjAZmU0nnT5cc/c1bhrriOmWdo1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709638619; c=relaxed/simple; bh=POkETsGRbketoDWXsvwDhq3gn8TxqRz5duFUPrt1aNw=; h=Message-ID:Subject:Date:From:To:Cc:References:In-Reply-To; b=jc6YVIQKH2JBsgPJa0QDd5uyGuKhgiRdWZ2/RKeIT+aMPS/ZeBe8UX6nupNf3GICcvO71pa65LIRDqJHxQJy+YLnykd/2sjwU6Km5LjBgxr+IK017ephi1l/Su1p/vDiJjMOgvPvrkhFOuaAyeTvv7H3HHxG4kkeWBn5VtZf86E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=wr4Xlb38; arc=none smtp.client-ip=115.124.30.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="wr4Xlb38" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1709638609; h=Message-ID:Subject:Date:From:To; bh=JO+6AB9KzJnq15c7g9gV2LhFHu7FmUfPL9YGcXxQKUI=; b=wr4Xlb381T/rtgFhBsqCUkscRn+yOIMMUtsoUz1dUnX27jv9hsfPP+jME37K0KlNdgFokwPiLnYddpnvXUcIOtERcN253hLje+1l9d4a0eBZZBNgIOvR7ATBOIZ292+MKh974HZwZKbIvYD2RhXnP8anq/Vy+v6AFU9D/wc0Toc= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R401e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0W1uAS0I_1709638606; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0W1uAS0I_1709638606) by smtp.aliyun-inc.com; Tue, 05 Mar 2024 19:36:47 +0800 Message-ID: <1709638595.0478082-2-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH vhost 3/4] virtio: vring_new_virtqueue(): pass struct instead of multi parameters Date: Tue, 5 Mar 2024 19:36:35 +0800 From: Xuan Zhuo To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: virtualization@lists.linux.dev, Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org References: <20240304114719.3710-1-xuanzhuo@linux.alibaba.com> <20240304114719.3710-4-xuanzhuo@linux.alibaba.com> <0cbf4910-ec0c-4b06-681e-aafae3720455@linux.intel.com> In-Reply-To: <0cbf4910-ec0c-4b06-681e-aafae3720455@linux.intel.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: On Tue, 5 Mar 2024 13:27:25 +0200 (EET), =?utf-8?q?Ilpo_J=C3=A4rvinen?= wrote: > On Mon, 4 Mar 2024, Xuan Zhuo wrote: > > > Just like find_vqs(), it is time to refactor the > > vring_new_virtqueue(). We pass the similar struct to > > vring_new_virtqueue. > > Please write a proper commit message here and do not just refer to > some other commit to describe what's going on here. YES. Thanks. > > -- > i. >