From mboxrd@z Thu Jan 1 00:00:00 1970 From: Farhan Ali Date: Fri, 26 Jan 2018 14:35:36 +0000 Subject: Re: [PATCH v1 0/2] Kconfig changes to enable Graphics Support for S390 Message-Id: <19306e74-7c9b-5644-6f08-bbaef226afd8@linux.vnet.ibm.com> References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Archive: List-Post: To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , linux-s390 , Linux Fbdev development list , Martin Schwidefsky , Christian Borntraeger , Stefan Kristiansson , Tomi Valkeinen List-ID: On 01/26/2018 08:41 AM, Geert Uytterhoeven wrote: > Hi Farhan, > > On Thu, Jan 25, 2018 at 4:47 PM, Farhan Ali wrote: >> This series of patches are in preparation for enabling an additional >> tty and console for a S390 KVM guest using a virtio-gpu device[1]. >> One of the steps to do this would be to enable CONFIG_VT for S390, >> and this would also require the dummy console (CONFIG_DUMMY_CONSOLE). >> >> Patch 1 enables the "Graphics support" menu which is >> needed to enable dummy console, since the VT layer needs it. >> >> Patch 2 fixes a Kconfig dependency issue for opencores >> framebuffer devices. This issue was exposed by the previous >> patch. >> >> Thanks >> Farhan >> >> >> [1] https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg04184.html >> >> Farhan Ali (2): >> Kconfig : Remove HAS_IOMEM dependency for Graphics support >> fbdev: Kconfig: Add HAS_IOMEM dependency for FB_OPENCORES >> >> drivers/video/Kconfig | 1 - >> drivers/video/fbdev/Kconfig | 2 +- >> 2 files changed, 1 insertion(+), 2 deletions(-) > > Shouldn't the order of your two patches be inverted, to avoid patch 1 > introducing > build breakage fixed by patch 2? > > Gr{oetje,eeting}s, > > Geert > Hi Geert, I wasn't sure what would be the best ordering since we would never hit the issue if patch 1 didn't exist. But if the preference is to invert the ordering of patches, then I will change the ordering. Thank you for reviewing. Thanks Farhan > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >