Re: [PATCH v2 2/4] s390/sclp: Add support for dynamic (de)configuration of memory

David Hildenbrand
2025-10-10T08:16:10Z

On 10.10.25 10:09, Sumanth Korikkar wrote:
>>> +struct sclp_mem {
>>> + struct kobject kobj;
>>> + unsigned int id;
>>> + unsigned int memmap_on_memory;
>>> + unsigned int config;
>>> +};
>>> +
>>> +struct sclp_mem_arg {
>>> + struct sclp_mem *sclp_mems;
>>> + struct kset *kset;
>>> +};
>>
>> Just one thought: if you keep either as global variable you wouldn't need
>> this. (I would just keep both as globals, but whatever you prefer)
>>
>> Whatever you prefer.
>

Feel free to add my

Acked-by: David Hildenbrand <david@redhat.com>

--
Cheers

David / dhildenb