Re: [PATCH 1/2] KVM: s390: Don't use %pK through tracepoints

Michael Mueller
2025-02-25T13:08:16Z

On 17.02.25 14:13, Thomas Weißschuh wrote:
> Restricted pointers ("%pK") are not meant to be used through TP_format().
> It can unintentionally expose security sensitive, raw pointer values.
>
> Use regular pointer formatting instead.
>
> Link: https://lore.kernel.org/lkml/20250113171731-dc10e3c1-da64-4af0-b767-7c7070468023@linutronix.de/
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Reviewed-by: Michael Mueller <mimu@linux.ibm.com>

> ---
> arch/s390/kvm/trace-s390.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/kvm/trace-s390.h b/arch/s390/kvm/trace-s390.h
> index 9ac92dbf680dbbe7703dd63945968b1cda46cf13..9e28f165c114caab99857ed3b53edc6ed5045dfa 100644
> --- a/arch/s390/kvm/trace-s390.h
> +++ b/arch/s390/kvm/trace-s390.h
> @@ -56,7 +56,7 @@ TRACE_EVENT(kvm_s390_create_vcpu,
> __entry->sie_block = sie_block;
> ),
>
> - TP_printk("create cpu %d at 0x%pK, sie block at 0x%pK",
> + TP_printk("create cpu %d at 0x%p, sie block at 0x%p",
> __entry->id, __entry->vcpu, __entry->sie_block)
> );
>
> @@ -255,7 +255,7 @@ TRACE_EVENT(kvm_s390_enable_css,
> __entry->kvm = kvm;
> ),
>
> - TP_printk("enabling channel I/O support (kvm @ %pK)\n",
> + TP_printk("enabling channel I/O support (kvm @ %p)\n",
> __entry->kvm)
> );
>
>