From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com ([205.139.110.61]:24101 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726694AbgEOH5o (ORCPT ); Fri, 15 May 2020 03:57:44 -0400 Subject: Re: [kvm-unit-tests PATCH v6 04/10] s390x: interrupt registration References: <1587725152-25569-1-git-send-email-pmorel@linux.ibm.com> <1587725152-25569-5-git-send-email-pmorel@linux.ibm.com> <20200514135805.77a7ae82.cohuck@redhat.com> <7da200e9-4cbe-0c77-833e-b4430cc2b80e@linux.ibm.com> From: David Hildenbrand Message-ID: <1ef24ac2-69c1-ce7e-2fba-a363093bba5c@redhat.com> Date: Fri, 15 May 2020 09:57:36 +0200 MIME-Version: 1.0 In-Reply-To: <7da200e9-4cbe-0c77-833e-b4430cc2b80e@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Pierre Morel , Cornelia Huck Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, thuth@redhat.com On 15.05.20 08:57, Pierre Morel wrote: > > > On 2020-05-14 13:58, Cornelia Huck wrote: >> On Fri, 24 Apr 2020 12:45:46 +0200 >> Pierre Morel wrote: >> >>> Let's make it possible to add and remove a custom io interrupt handler, >>> that can be used instead of the normal one. >>> >>> Signed-off-by: Pierre Morel >>> Reviewed-by: Thomas Huth >>> Reviewed-by: David Hildenbrand >>> Reviewed-by: Janosch Frank >>> --- >>> lib/s390x/interrupt.c | 23 ++++++++++++++++++++++- >>> lib/s390x/interrupt.h | 8 ++++++++ >>> 2 files changed, 30 insertions(+), 1 deletion(-) >>> create mode 100644 lib/s390x/interrupt.h >> >> As the "normal one" means "no handler, just abort", is there any reason >> not simply to always provide one? What is the use case for multiple I/O >> interrupt handlers? >> > > I can only agree, I proposed this initially. > David asked for a registration. > I don't understand "not simply to always provide one" or "multiple I/O interrupt handlers". There is always exactly *one* handler void handle_io_int(void) { ... } All we do here, is to allow to register a callback from the handler, e.g., to verify in a test case that a specific I/O interrupt was received. -- Thanks, David / dhildenb