From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 18 Jun 2007 10:23:43 +0200 From: Heiko Carstens Subject: Re: [patch] use __asm__ rather than asm in asm-s390/ptrace.h Message-ID: <20070618082343.GB3580@osiris.boeblingen.de.ibm.com> References: <200706180223.07122.vapier@gentoo.org> <20070618073605.GA3580@osiris.boeblingen.de.ibm.com> <1182154518.3335.4.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1182154518.3335.4.camel@localhost> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Martin Schwidefsky Cc: Mike Frysinger , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org List-ID: On Mon, Jun 18, 2007 at 10:15:18AM +0200, Martin Schwidefsky wrote: > On Mon, 2007-06-18 at 09:36 +0200, Heiko Carstens wrote: > > Hmm.. spka is a sort of priviledged instruction and shouldn't be > > user space visible. > > I will move it so it's under #ifdef __KERNEL__. > > Yes, I think this is better. On a side node, why did we add psw_set_key > to ptrace.h? processor.h would have made more sense, no? It sets the key > in the psw, it is not usable in userspace and ptrace doesn't provide an > interface for reading/writing to the psw key. So a patch that moves the > inline to processor.h alongside __load_psw and __load_psw_mask would be > my solution. Yes. Moved it to processor.h instead :)