From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 18 Jun 2007 21:00:09 +0200 From: Sam Ravnborg Subject: Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h Message-ID: <20070618190009.GB25340@uranus.ravnborg.org> References: <200706171833.29046.vapier@gentoo.org> <20070618183450.GA17112@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070618183450.GA17112@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Christoph Hellwig , Mike Frysinger , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, rmk@arm.linux.org.uk List-ID: On Mon, Jun 18, 2007 at 07:34:50PM +0100, Christoph Hellwig wrote: > On Sun, Jun 17, 2007 at 06:33:28PM -0400, Mike Frysinger wrote: > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > headers can be used with gcc's -std=c99. > > We should not allow inline assemly in the exported part of userspace headers > at all. These headers must only include defintions for the kernel <-> user > ABI, and should not include code at all. Do you imply that if we see asm or __asm__ in user space headers we ougth to warn about it? Seems at least sensible to me but if we introduce such a check we should kill all offenders first - which Mike's patches seems to trigger for some part. Sam