From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1761198AbXKPPkS@vger.kernel.org>
Date: Fri, 16 Nov 2007 16:39:28 +0100
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [patch 3/6] sclp: call sclp_init() from start_kernel().
Message-ID: <20071116153928.GA6162@osiris.boeblingen.de.ibm.com>
References: <20071116142942.978412023@de.ibm.com> <20071116143321.502691250@de.ibm.com> <20071116150942.GA5748@wavehammer.waldi.eu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071116150942.GA5748@wavehammer.waldi.eu.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Archive: <https://lore.kernel.org/lkml/>
List-Post: <mailto:linux-kernel@vger.kernel.org>
To: Bastian Blank <bastian@waldi.eu.org>, Martin Schwidefsky <schwidefsky@de.ibm.com>, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
List-ID: <linux-s390.vger.kernel.org>

On Fri, Nov 16, 2007 at 04:09:42PM +0100, Bastian Blank wrote:
> On Fri, Nov 16, 2007 at 03:29:45PM +0100, Martin Schwidefsky wrote:
> >  #else
> >  static inline void acpi_early_init(void) { }
> >  #endif
> > +#ifdef CONFIG_S390
> > +extern int sclp_init(void);
> > +#else
> > +static inline int sclp_init(void) {return 0;}
> > +#endif
> >  #ifndef CONFIG_DEBUG_RODATA
> >  static inline void mark_rodata_ro(void) { }
> >  #endif
> > @@ -643,6 +648,7 @@ asmlinkage void __init start_kernel(void
> >  	check_bugs();
> >  
> >  	acpi_early_init(); /* before LAPIC and SMP init */
> > +	sclp_init();
> 
> What happens if sclp_init fails? The other early init calls explicitely
> returns void and handels the error internal.

Nothing. I used to have an sclp call within __cpu_up() but that is gone
since I rewrote the patch that follows this one.
So this patch is just a leftover and I forgot that it isn't needed anymore.
Will be dropped.

Thanks for the hint!