public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 05/21] Cleanup 3215 printk messages.
Date: Wed, 25 Jun 2008 16:35:04 +0200	[thread overview]
Message-ID: <20080625143612.618388443@de.ibm.com> (raw)
In-Reply-To: 20080625143459.100139455@de.ibm.com

[-- Attachment #1: 804-printk-con3215.diff --]
[-- Type: text/plain, Size: 2856 bytes --]

From: Martin Schwidefsky <schwidefsky@de.ibm.com>

Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

 drivers/s390/char/con3215.c |   23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

Index: quilt-2.6/drivers/s390/char/con3215.c
===================================================================
--- quilt-2.6.orig/drivers/s390/char/con3215.c
+++ quilt-2.6/drivers/s390/char/con3215.c
@@ -93,9 +93,6 @@ struct raw3215_info {
 	struct raw3215_req *queued_write;/* pointer to queued write requests */
 	wait_queue_head_t empty_wait; /* wait queue for flushing */
 	struct timer_list timer;      /* timer for delayed output */
-	char *message;		      /* pending message from raw3215_irq */
-	int msg_dstat;		      /* dstat for pending message */
-	int msg_cstat;		      /* cstat for pending message */
 	int line_pos;		      /* position on the line (for tabs) */
 	char ubuffer[80];	      /* copy_from_user buffer */
 };
@@ -359,11 +356,6 @@ raw3215_tasklet(void *data)
 	raw3215_mk_write_req(raw);
 	raw3215_try_io(raw);
 	spin_unlock_irqrestore(get_ccwdev_lock(raw->cdev), flags);
-	/* Check for pending message from raw3215_irq */
-	if (raw->message != NULL) {
-		printk(raw->message, raw->msg_dstat, raw->msg_cstat);
-		raw->message = NULL;
-	}
 	tty = raw->tty;
 	if (tty != NULL &&
 	    RAW3215_BUFFER_SIZE - raw->count >= RAW3215_MIN_SPACE) {
@@ -387,14 +379,8 @@ raw3215_irq(struct ccw_device *cdev, uns
 	req = (struct raw3215_req *) intparm;
 	cstat = irb->scsw.cmd.cstat;
 	dstat = irb->scsw.cmd.dstat;
-	if (cstat != 0) {
-		raw->message = KERN_WARNING
-			"Got nonzero channel status in raw3215_irq "
-			"(dev sts 0x%2x, sch sts 0x%2x)";
-		raw->msg_dstat = dstat;
-		raw->msg_cstat = cstat;
+	if (cstat != 0)
 		tasklet_schedule(&raw->tasklet);
-	}
 	if (dstat & 0x01) { /* we got a unit exception */
 		dstat &= ~0x01;	 /* we can ignore it */
 	}
@@ -481,11 +467,6 @@ raw3215_irq(struct ccw_device *cdev, uns
 			raw->flags &= ~RAW3215_WORKING;
 			raw3215_free_req(req);
 		}
-		raw->message = KERN_WARNING
-			"Spurious interrupt in in raw3215_irq "
-			"(dev sts 0x%2x, sch sts 0x%2x)";
-		raw->msg_dstat = dstat;
-		raw->msg_cstat = cstat;
 		tasklet_schedule(&raw->tasklet);
 	}
 	return;
@@ -883,7 +864,6 @@ con3215_init(void)
 		free_bootmem((unsigned long) raw->buffer, RAW3215_BUFFER_SIZE);
 		free_bootmem((unsigned long) raw, sizeof(struct raw3215_info));
 		raw3215[0] = NULL;
-		printk("Couldn't find a 3215 console device\n");
 		return -ENODEV;
 	}
 	register_console(&con3215);
@@ -1157,7 +1137,6 @@ tty3215_init(void)
 	tty_set_operations(driver, &tty3215_ops);
 	ret = tty_register_driver(driver);
 	if (ret) {
-		printk("Couldn't register tty3215 driver\n");
 		put_tty_driver(driver);
 		return ret;
 	}

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

  parent reply	other threads:[~2008-06-25 14:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 14:34 [patch 00/21] s390 printk message cleanup Martin Schwidefsky
2008-06-25 14:35 ` [patch 01/21] Cleanup cio printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 02/21] Cleanup vtime " Martin Schwidefsky
2008-06-25 14:35 ` [patch 03/21] Cleanup xpram " Martin Schwidefsky
2008-06-25 14:35 ` [patch 04/21] Cleanup 3270 " Martin Schwidefsky
2008-06-25 14:35 ` Martin Schwidefsky [this message]
2008-06-25 14:35 ` [patch 06/21] Cleanup zcrypt " Martin Schwidefsky
2008-06-25 14:35 ` [patch 07/21] Cleanup sclp " Martin Schwidefsky
2008-06-25 15:15   ` Bastian Blank
2008-06-26  7:26     ` Martin Schwidefsky
2008-06-25 14:35 ` [patch 08/21] Cleanup printk messages in dcssblk Martin Schwidefsky
2008-06-25 14:35 ` [patch 09/21] Cleanup vmwatch printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 10/21] Cleanup kprobes " Martin Schwidefsky
2008-06-25 14:35 ` [patch 11/21] Cleanup cpacf " Martin Schwidefsky
2008-06-25 14:35 ` [patch 12/21] Cleanup smsgiucv " Martin Schwidefsky
2008-06-25 14:35 ` [patch 13/21] Cleanup appldata " Martin Schwidefsky
2008-06-25 14:35 ` [patch 14/21] Cleanup monreader " Martin Schwidefsky
2008-06-25 14:35 ` [patch 15/21] Cleanup s390 debug feature print messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 16/21] Cleanup vmlogrdr printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 17/21] Cleanup zfcp dumper " Martin Schwidefsky
2008-06-25 14:35 ` [patch 18/21] Cleanup iucv " Martin Schwidefsky
2008-06-25 14:35 ` [patch 19/21] Cleanup netiucv " Martin Schwidefsky
2008-06-25 14:35 ` [patch 20/21] Cleanup qeth print messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 21/21] Cleanup lcs printk messages Martin Schwidefsky
2008-06-27  4:54   ` Jeff Garzik
2008-06-27  6:58     ` Martin Schwidefsky
2008-06-27  7:08       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625143612.618388443@de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox