public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 09/21] Cleanup vmwatch printk messages.
Date: Wed, 25 Jun 2008 16:35:08 +0200	[thread overview]
Message-ID: <20080625143613.663567264@de.ibm.com> (raw)
In-Reply-To: 20080625143459.100139455@de.ibm.com

[-- Attachment #1: 808-printk-vmwatchdog.diff --]
[-- Type: text/plain, Size: 1458 bytes --]

From: Martin Schwidefsky <schwidefsky@de.ibm.com>

Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

 drivers/s390/char/vmwatchdog.c |   16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

Index: quilt-2.6/drivers/s390/char/vmwatchdog.c
===================================================================
--- quilt-2.6.orig/drivers/s390/char/vmwatchdog.c
+++ quilt-2.6/drivers/s390/char/vmwatchdog.c
@@ -92,23 +92,15 @@ static int vmwdt_keepalive(void)
 
 	func = vmwdt_conceal ? (wdt_init | wdt_conceal) : wdt_init;
 	ret = __diag288(func, vmwdt_interval, ebc_cmd, len);
+	WARN_ON(ret != 0);
 	kfree(ebc_cmd);
-
-	if (ret) {
-		printk(KERN_WARNING "%s: problem setting interval %d, "
-			"cmd %s\n", __func__, vmwdt_interval,
-			vmwdt_cmd);
-	}
 	return ret;
 }
 
 static int vmwdt_disable(void)
 {
 	int ret = __diag288(wdt_cancel, 0, "", 0);
-	if (ret) {
-		printk(KERN_WARNING "%s: problem disabling watchdog\n",
-			__func__);
-	}
+	WARN_ON(ret != 0);
 	return ret;
 }
 
@@ -121,10 +113,8 @@ static int __init vmwdt_probe(void)
 	static char __initdata ebc_begin[] = {
 		194, 197, 199, 201, 213
 	};
-	if (__diag288(wdt_init, 15, ebc_begin, sizeof(ebc_begin)) != 0) {
-		printk(KERN_INFO "z/VM watchdog not available\n");
+	if (__diag288(wdt_init, 15, ebc_begin, sizeof(ebc_begin)) != 0)
 		return -EINVAL;
-	}
 	return vmwdt_disable();
 }
 

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

  parent reply	other threads:[~2008-06-25 14:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 14:34 [patch 00/21] s390 printk message cleanup Martin Schwidefsky
2008-06-25 14:35 ` [patch 01/21] Cleanup cio printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 02/21] Cleanup vtime " Martin Schwidefsky
2008-06-25 14:35 ` [patch 03/21] Cleanup xpram " Martin Schwidefsky
2008-06-25 14:35 ` [patch 04/21] Cleanup 3270 " Martin Schwidefsky
2008-06-25 14:35 ` [patch 05/21] Cleanup 3215 " Martin Schwidefsky
2008-06-25 14:35 ` [patch 06/21] Cleanup zcrypt " Martin Schwidefsky
2008-06-25 14:35 ` [patch 07/21] Cleanup sclp " Martin Schwidefsky
2008-06-25 15:15   ` Bastian Blank
2008-06-26  7:26     ` Martin Schwidefsky
2008-06-25 14:35 ` [patch 08/21] Cleanup printk messages in dcssblk Martin Schwidefsky
2008-06-25 14:35 ` Martin Schwidefsky [this message]
2008-06-25 14:35 ` [patch 10/21] Cleanup kprobes printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 11/21] Cleanup cpacf " Martin Schwidefsky
2008-06-25 14:35 ` [patch 12/21] Cleanup smsgiucv " Martin Schwidefsky
2008-06-25 14:35 ` [patch 13/21] Cleanup appldata " Martin Schwidefsky
2008-06-25 14:35 ` [patch 14/21] Cleanup monreader " Martin Schwidefsky
2008-06-25 14:35 ` [patch 15/21] Cleanup s390 debug feature print messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 16/21] Cleanup vmlogrdr printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 17/21] Cleanup zfcp dumper " Martin Schwidefsky
2008-06-25 14:35 ` [patch 18/21] Cleanup iucv " Martin Schwidefsky
2008-06-25 14:35 ` [patch 19/21] Cleanup netiucv " Martin Schwidefsky
2008-06-25 14:35 ` [patch 20/21] Cleanup qeth print messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 21/21] Cleanup lcs printk messages Martin Schwidefsky
2008-06-27  4:54   ` Jeff Garzik
2008-06-27  6:58     ` Martin Schwidefsky
2008-06-27  7:08       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625143613.663567264@de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox