public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Jeff Garzik <jgarzik@redhat.com>,
	Frank Blaschka <frank.blaschka@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 20/21] Cleanup qeth print messages.
Date: Wed, 25 Jun 2008 16:35:19 +0200	[thread overview]
Message-ID: <20080625143616.492222559@de.ibm.com> (raw)
In-Reply-To: 20080625143459.100139455@de.ibm.com

[-- Attachment #1: 819-printk-qeth.diff --]
[-- Type: text/plain, Size: 1827 bytes --]

From: Frank Blaschka <frank.blaschka@de.ibm.com>

Cc: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

 drivers/s390/net/qeth_core_main.c |    3 +--
 drivers/s390/net/qeth_l3_main.c   |    9 +--------
 2 files changed, 2 insertions(+), 10 deletions(-)

Index: quilt-2.6/drivers/s390/net/qeth_core_main.c
===================================================================
--- quilt-2.6.orig/drivers/s390/net/qeth_core_main.c
+++ quilt-2.6/drivers/s390/net/qeth_core_main.c
@@ -420,7 +420,7 @@ static struct qeth_ipa_cmd *qeth_check_i
 				QETH_DBF_TEXT(TRACE, 3, "urla");
 				break;
 			default:
-				PRINT_WARN("Received data is IPA "
+				QETH_DBF_MESSAGE(2, "Received data is IPA "
 					   "but not a reply!\n");
 				break;
 			}
@@ -4092,7 +4092,6 @@ static int qeth_core_probe_device(struct
 
 	rc = qeth_determine_card_type(card);
 	if (rc) {
-		PRINT_WARN("%s: not a valid card type\n", __func__);
 		QETH_DBF_TEXT_(SETUP, 2, "3err%d", rc);
 		goto err_card;
 	}
Index: quilt-2.6/drivers/s390/net/qeth_l3_main.c
===================================================================
--- quilt-2.6.orig/drivers/s390/net/qeth_l3_main.c
+++ quilt-2.6/drivers/s390/net/qeth_l3_main.c
@@ -944,15 +944,8 @@ static int qeth_l3_deregister_addr_entry
 	else
 		rc = qeth_l3_send_setdelip(card, addr, IPA_CMD_DELIP,
 					addr->del_flags);
-	if (rc) {
+	if (rc)
 		QETH_DBF_TEXT(TRACE, 2, "failed");
-		/* TODO: re-activate this warning as soon as we have a
-		 * clean mirco code
-		qeth_ipaddr_to_string(addr->proto, (u8 *)&addr->u, buf);
-		PRINT_WARN("Could not deregister IP address %s (rc=%x)\n",
-			   buf, rc);
-		*/
-	}
 
 	return rc;
 }

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

  parent reply	other threads:[~2008-06-25 14:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 14:34 [patch 00/21] s390 printk message cleanup Martin Schwidefsky
2008-06-25 14:35 ` [patch 01/21] Cleanup cio printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 02/21] Cleanup vtime " Martin Schwidefsky
2008-06-25 14:35 ` [patch 03/21] Cleanup xpram " Martin Schwidefsky
2008-06-25 14:35 ` [patch 04/21] Cleanup 3270 " Martin Schwidefsky
2008-06-25 14:35 ` [patch 05/21] Cleanup 3215 " Martin Schwidefsky
2008-06-25 14:35 ` [patch 06/21] Cleanup zcrypt " Martin Schwidefsky
2008-06-25 14:35 ` [patch 07/21] Cleanup sclp " Martin Schwidefsky
2008-06-25 15:15   ` Bastian Blank
2008-06-26  7:26     ` Martin Schwidefsky
2008-06-25 14:35 ` [patch 08/21] Cleanup printk messages in dcssblk Martin Schwidefsky
2008-06-25 14:35 ` [patch 09/21] Cleanup vmwatch printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 10/21] Cleanup kprobes " Martin Schwidefsky
2008-06-25 14:35 ` [patch 11/21] Cleanup cpacf " Martin Schwidefsky
2008-06-25 14:35 ` [patch 12/21] Cleanup smsgiucv " Martin Schwidefsky
2008-06-25 14:35 ` [patch 13/21] Cleanup appldata " Martin Schwidefsky
2008-06-25 14:35 ` [patch 14/21] Cleanup monreader " Martin Schwidefsky
2008-06-25 14:35 ` [patch 15/21] Cleanup s390 debug feature print messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 16/21] Cleanup vmlogrdr printk messages Martin Schwidefsky
2008-06-25 14:35 ` [patch 17/21] Cleanup zfcp dumper " Martin Schwidefsky
2008-06-25 14:35 ` [patch 18/21] Cleanup iucv " Martin Schwidefsky
2008-06-25 14:35 ` [patch 19/21] Cleanup netiucv " Martin Schwidefsky
2008-06-25 14:35 ` Martin Schwidefsky [this message]
2008-06-25 14:35 ` [patch 21/21] Cleanup lcs " Martin Schwidefsky
2008-06-27  4:54   ` Jeff Garzik
2008-06-27  6:58     ` Martin Schwidefsky
2008-06-27  7:08       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625143616.492222559@de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=frank.blaschka@de.ibm.com \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox