public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Christof Schmitt <christof.schmitt@de.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
	Christof Schmitt <christof.schmitt@de.ibm.com>,
	Swen Schillig <swen@vnet.ibm.com>
Subject: [patch 02/11] zfcp: Fix error checking for ELS ADISC requests
Date: Wed, 02 Jul 2008 10:56:32 +0200	[thread overview]
Message-ID: <20080702085947.559989000@de.ibm.com> (raw)
In-Reply-To: 20080702085630.473635000@de.ibm.com

[-- Attachment #1: fix-els-adisc.diff --]
[-- Type: text/plain, Size: 796 bytes --]

From: Christof Schmitt <christof.schmitt@de.ibm.com>

Correctly check the status for ELS ADISC requests. 0 means success.

Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
---
 drivers/s390/scsi/zfcp_fc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/s390/scsi/zfcp_fc.c	2008-06-27 18:07:26.000000000 +0200
+++ b/drivers/s390/scsi/zfcp_fc.c	2008-06-27 18:07:43.000000000 +0200
@@ -263,7 +263,7 @@ static void zfcp_fc_adisc_handler(unsign
 	struct zfcp_port *port = adisc->els.port;
 	struct zfcp_ls_adisc_acc *ls_adisc = &adisc->ls_adisc_acc;
 
-	if (!adisc->els.status) {
+	if (adisc->els.status) {
 		/* request rejected or timed out */
 		zfcp_erp_port_forced_reopen(port, 0, 63, NULL);
 		goto out;

-- 

  parent reply	other threads:[~2008-07-02  8:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-02  8:56 [patch 00/11] Updated zfcp patches for 2.6.27 Christof Schmitt
2008-07-02  8:56 ` [patch 01/11] zfcp: wait until adapter is finished with ERP during auto-port Christof Schmitt
2008-07-02  8:56 ` Christof Schmitt [this message]
2008-07-02  8:56 ` [patch 03/11] zfcp: Adapter reopen for large number of unsolicited status Christof Schmitt
2008-07-02  8:56 ` [patch 04/11] zfcp: Small QDIO cleanups Christof Schmitt
2008-07-02  8:56 ` [patch 05/11] zfcp: Move status accessors from zfcp to SCSI include file Christof Schmitt
2008-07-02  8:56 ` [patch 06/11] zfcp: Cleanup of code in zfcp_scsi.c Christof Schmitt
2008-07-02  8:56 ` [patch 07/11] zfcp: Cleanup of code in zfcp_aux.c Christof Schmitt
2008-07-02  8:56 ` [patch 08/11] zfcp: consolidate sysfs things into one file Christof Schmitt
2008-07-02  8:56 ` [patch 09/11] zfcp: zfcp_fsf cleanup Christof Schmitt
2008-07-02  8:56 ` [patch 10/11] zfcp: Cleanup code in zfcp_erp.c Christof Schmitt
2008-07-02  8:56 ` [patch 11/11] zfcp: Cleanup external header file Christof Schmitt
     [not found] ` <1214992150.4974.16.camel@subratamodak.linux.ibm.com>
2008-07-02 11:31   ` [patch 00/11] Updated zfcp patches for 2.6.27 Christof Schmitt
  -- strict thread matches above, loose matches on Subject: below --
2008-06-30 10:52 [patch 00/11] zfcp updates " christof.schmitt
2008-06-30 10:52 ` [patch 02/11] zfcp: Fix error checking for ELS ADISC requests christof.schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080702085947.559989000@de.ibm.com \
    --to=christof.schmitt@de.ibm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=swen@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox