From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 15 Jul 2008 17:10:25 +0900 From: Akinobu Mita Subject: [PATCH] iucv: fix memory leak in cpu hotplug error path. Message-ID: <20080715081025.GB22068@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: linux-kernel@vger.kernel.org Cc: "David S. Miller" , netdev@vger.kernel.org, Ursula Braun , linux390@de.ibm.com, linux-s390@vger.kernel.org List-ID: Fix memory leak in error path in CPU_UP_PREPARE notifier. Signed-off-by: Akinobu Mita Cc: David S. Miller Cc: netdev@vger.kernel.org Cc: Ursula Braun Cc: linux390@de.ibm.com Cc: linux-s390@vger.kernel.org --- net/iucv/iucv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Index: 2.6-mmotm/net/iucv/iucv.c =================================================================== --- 2.6-mmotm.orig/net/iucv/iucv.c +++ 2.6-mmotm/net/iucv/iucv.c @@ -567,8 +567,11 @@ static int __cpuinit iucv_cpu_notify(str return NOTIFY_BAD; iucv_param[cpu] = kmalloc_node(sizeof(union iucv_param), GFP_KERNEL|GFP_DMA, cpu_to_node(cpu)); - if (!iucv_param[cpu]) + if (!iucv_param[cpu]) { + kfree(iucv_irq_data[cpu]); + iucv_irq_data[cpu] = NULL; return NOTIFY_BAD; + } break; case CPU_UP_CANCELED: case CPU_UP_CANCELED_FROZEN: