From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Arnd Bergmann Subject: Re: [RFC: 2.6 patch] s390: use kernel/uid.c Date: Fri, 15 Aug 2008 17:34:43 +0200 References: <20080810204031.GC8399@cs181140183.pp.htv.fi> In-Reply-To: <20080810204031.GC8399@cs181140183.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808151734.43710.arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Adrian Bunk Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: On Sunday 10 August 2008, Adrian Bunk wrote: > Unless I missed a twist the only reason for s390 to not use the code in > kernel/uid.c was that it copied the code from sparc64 (that is now > being changed in a similar way by David). > > Signed-off-by: Adrian Bunk > I tried doing this before but couldn't figure out an easy way, but the circumstances may have changed by now. Back then, the basic problem was that CONFIG_UID16 had side-effects that break the 64-bit versions of some syscalls. I don't see that being the case any more, but from what I can tell, you still need to add definitions for __kernel_old_uid_t etc on s390x. If that does the trick, great work! Arnd <><