From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 12 Dec 2008 10:29:51 +0100 From: Cornelia Huck Subject: Re: [PATCH 4/4] s390: remove s390_root_dev_*() Message-ID: <20081212102951.01446f22@gondolin> In-Reply-To: <20081211180025.045b9b4a@gondolin> References: <1229012203.7968.79.camel@blaa> <1229012216-4211-1-git-send-email-markmc@redhat.com> <1229012216-4211-2-git-send-email-markmc@redhat.com> <1229012216-4211-3-git-send-email-markmc@redhat.com> <1229012216-4211-4-git-send-email-markmc@redhat.com> <20081211180025.045b9b4a@gondolin> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Mark McLoughlin Cc: Greg KH , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , Anthony Liguori , Kay Sievers , linux-s390@vger.kernel.org, Heiko Carstens , Martin Schwidefsky List-ID: On Thu, 11 Dec 2008 18:00:25 +0100, Cornelia Huck wrote: > On Thu, 11 Dec 2008 16:16:56 +0000, > Mark McLoughlin wrote: > > > Replace s390_root_dev_register() with root_device_register() etc. > > Nice, one more special case generalized :) I'll give it a run. You missed one occurrence in iucv (see below); with that patch applied, everything seems to work as expected, both for root devices created by built-ins and by modules. --- net/iucv/iucv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.orig/net/iucv/iucv.c +++ linux-2.6/net/iucv/iucv.c @@ -1682,7 +1682,7 @@ static void __exit iucv_exit(void) kfree(iucv_irq_data[cpu]); iucv_irq_data[cpu] = NULL; } - s390_root_dev_unregister(iucv_root); + root_device_unregister(iucv_root); bus_unregister(&iucv_bus); unregister_external_interrupt(0x4000, iucv_external_interrupt); }