Re: [patch 10/14] smp: fix cpu_possible_map initialization

Rusty Russell
2009-04-15T02:06:34Z

On Tue, 14 Apr 2009 11:23:37 pm Martin Schwidefsky wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> The cpu_possible_map by default is initialized with all ones in s390.
> If the kernel paramert possible_cpus=<x> is passed the cpu_possible_map
> is supposed to have x bits set.
> However the current code just sets the x bits without clearing the NR_CPUS
> bits that were already set. So we end up with an unchanged map that has
> all bits set.
> To fix this just clear the map before setting any new bits.

You're right; I created this patch back before I did the
CONFIG_INIT_ALL_POSSIBLE patch.

It'd be nice to wean S390 off CONFIG_INIT_ALL_POSSIBLE, then there'd
only be two (parisc and m32r). But it's a minor wart.

Thanks,
Rusty.