From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch 4/5] [PATCH] qeth: rework TSO functions Date: Fri, 13 Nov 2009 20:36:21 -0800 (PST) Message-ID: <20091113.203621.39740182.davem@davemloft.net> References: <20091112101140.882313000@de.ibm.com> <20091112101301.126320000@de.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091112101301.126320000@de.ibm.com> Sender: netdev-owner@vger.kernel.org List-Archive: List-Post: To: frank.blaschka@de.ibm.com Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org List-ID: From: frank.blaschka@de.ibm.com Date: Thu, 12 Nov 2009 11:11:44 +0100 > From: Frank Blaschka > > The maximum TSO size OSA can handle is 15 * PAGE_SIZE. This > patch reduces gso_max_size to this value and adds some sanity > checks and statistics to the TSO implementation. > Since only layer 3 is able to do TSO move all TSO related functions > to the qeth_l3 module. > > Signed-off-by: Frank Blaschka Please don't add sysctl knobs for getting and setting TSO enabling, that's what ethtool is for.