From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 15 Nov 2010 15:50:57 +0100 From: Martin Schwidefsky Subject: Re: [RFC][PATCH v2 4/7] taskstats: Add per task steal time accounting Message-ID: <20101115155057.15f3be35@mschwide.boeblingen.de.ibm.com> In-Reply-To: <1289677083.2109.167.camel@laptop> References: <20101111170352.732381138@linux.vnet.ibm.com> <20101111170815.024542355@linux.vnet.ibm.com> <1289677083.2109.167.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Peter Zijlstra Cc: Michael Holzheu , Shailabh Nagar , Andrew Morton , Venkatesh Pallipadi , Suresh Siddha , Ingo Molnar , Oleg Nesterov , John stultz , Thomas Gleixner , Balbir Singh , Heiko Carstens , Roland McGrath , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org List-ID: On Sat, 13 Nov 2010 20:38:02 +0100 Peter Zijlstra wrote: > On Thu, 2010-11-11 at 18:03 +0100, Michael Holzheu wrote: > > From: Michael Holzheu > > > > Currently steal time is only accounted for the whole system. With this > > patch we add steal time to the per task CPU time accounting. > > The triplet "user time", "system time" and "steal time" represents > > all consumed CPU time on hypervisor based systems. > > Does that really make sense? Its not like the hypervisor really knows > anything about tasks and won't steal from one? Its really a vcpu > feature. > > What added benefit will all this extra accounting give? Currently the linux kernel keeps track of used cpu cycles per task, steal time is reported only per cpu. With the patch steal cycles are reported per task just like used cpu cycles, giving the complete picture on a per task basis. Without the patch you don't know if the task has been waiting or got its cycles stolen. A matter of granularity. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.