From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: KOSAKI Motohiro Subject: Re: [PATCH] s390: convert old cpumask API into new one In-Reply-To: References: <20110429000304.3D60.A69D9226@jp.fujitsu.com> Message-Id: <20110429004726.3D83.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Date: Fri, 29 Apr 2011 00:45:47 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Thiago Farina Cc: kosaki.motohiro@jp.fujitsu.com, LKML , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, linux-s390@vger.kernel.org List-ID: > > @@ -1016,21 +1016,21 @@ int __ref smp_rescan_cpus(void) > > > >        get_online_cpus(); > >        mutex_lock(&smp_cpu_state_mutex); > > -       newcpus = cpu_present_map; > > +       cpumask_copy(&newcpus, cpu_present_mask); > >        rc = __smp_rescan_cpus(); > >        if (rc) > >                goto out; > > -       cpus_andnot(newcpus, cpu_present_map, newcpus); > > -       for_each_cpu_mask(cpu, newcpus) { > > +       cpumask_andnot(&newcpus, cpu_present_mask, &newcpus); > > +       for_each_cpu(cpu,&newcpus) { > please, could you add a space between cpu and ,&newcpus? Thank you for finding. >From 46812a238d85243a18dcec0749ba42d5f1a0e1ab Mon Sep 17 00:00:00 2001 From: KOSAKI Motohiro Date: Fri, 29 Apr 2011 00:44:43 +0900 Subject: [PATCH] s390: coding style fix Signed-off-by: KOSAKI Motohiro --- arch/s390/kernel/smp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c index 4cc09b8..a80798b 100644 --- a/arch/s390/kernel/smp.c +++ b/arch/s390/kernel/smp.c @@ -1021,7 +1021,7 @@ int __ref smp_rescan_cpus(void) if (rc) goto out; cpumask_andnot(&newcpus, cpu_present_mask, &newcpus); - for_each_cpu(cpu,&newcpus) { + for_each_cpu(cpu, &newcpus) { rc = smp_add_present_cpu(cpu); if (rc) set_cpu_present(cpu, false); -- 1.7.3.1