Re: [patch 1/1] [PATCH] include storage keys in hibernation image.

Rafael J. Wysocki
2011-06-15T23:21:26Z

On Wednesday, June 15, 2011, Martin Schwidefsky wrote:
> On Tue, 14 Jun 2011 22:50:14 +0200
...
> > Well, I'm sure we can handle that. :-)
> >
> > I thought of the following approach:
> >
> > * Allocate memory for saving the relevant bits of the storage keys before
> > the memory preallocation kicks in.
> >
> > * Save the storage key bits to that memory before creating the image (be
> > careful about the storage keys of the pages they are being stored into).
> >
> > * After getting control from the boot kernel, restore the storage key bits
> > saved before creating the image.
> >
> > * Free additional memory used for storing them.
> >
> > This way we wouldn't have to worry about any interactions with
> > snapshot_read_next / snapshot_write_next etc.
>
> Well before the preallocation kicked in we don't know which are the relevant
> storage keys. The only other option would be to store all of them which I
> consider to be a inferior solution.

OK, I see your point. You think it's necessary to save the entire storage key
for each page and you'd like to save storage keys only for those pages, whose
contents is going to be saved in the image.

Now, I need to look at your original patch again. :-)