From: Robert Richter <robert.richter@amd.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: oprofile patch broke s390 build in tip/perf/core
Date: Wed, 21 Dec 2011 18:53:26 +0100 [thread overview]
Message-ID: <20111221175326.GM16765@erda.amd.com> (raw)
In-Reply-To: <1324488646.5916.107.camel@gandalf.stny.rr.com>
On 21.12.11 12:30:46, Steven Rostedt wrote:
> In doing my tests last night before sending out my patch series this
> morning, I found that s390 build didn't work, but it wasn't due to my
> patches. I removed all my patches and built with latest mainline (which
> builds fine), and then merged the current tip/perf/core. The result
> didn't build.
>
> I kicked off a ktest git bisect with last night's Linus tree as good,
> and with the merged in tip/perf/core as bad. It ended up with this patch
> that broke the build (which looks like a likely suspect).
>
>
> The break is this:
>
> LD .tmp_vmlinux1
> arch/s390/oprofile/built-in.o: In function `oprofile_arch_exit':
> (.text+0x3f52): undefined reference to `oprofile_timer_exit'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
A fix is already in tip/perf/core:
f8c8520 oprofile: Fix oprofile_timer_exit() breakage
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
next prev parent reply other threads:[~2011-12-21 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 17:30 oprofile patch broke s390 build in tip/perf/core Steven Rostedt
2011-12-21 17:53 ` Robert Richter [this message]
2011-12-21 18:07 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221175326.GM16765@erda.amd.com \
--to=robert.richter@amd.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox