oprofile patch broke s390 build in tip/perf/core

oprofile patch broke s390 build in tip/perf/core

[Steven Rostedt]

Hi,

In doing my tests last night before sending out my patch series this
morning, I found that s390 build didn't work, but it wasn't due to my
patches. I removed all my patches and built with latest mainline (which
builds fine), and then merged the current tip/perf/core. The result
didn't build.

I kicked off a ktest git bisect with last night's Linus tree as good,
and with the merged in tip/perf/core as bad. It ended up with this patch
that broke the build (which looks like a likely suspect).


The break is this:

  LD      .tmp_vmlinux1
arch/s390/oprofile/built-in.o: In function `oprofile_arch_exit':
(.text+0x3f52): undefined reference to `oprofile_timer_exit'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [sub-make] Error 2

The patch the bisect found that breaks the build is this:

commit 75c43a20b220f885c39ffa7cdbbb1191e257a9a9
Author: Robert Richter <robert.richter@amd.com>
Date:   Fri Oct 14 15:46:10 2011 +0200

    oprofile: Remove exit function for timer mode
    
    Remove exit functions by moving init/exit code to oprofile's setup/
    shutdown functions. Doing so the oprofile module exit code will be
    easier and less error-prone.
    
    Signed-off-by: Robert Richter <robert.richter@amd.com>


-- Steve

Re: oprofile patch broke s390 build in tip/perf/core

[Robert Richter]

On 21.12.11 12:30:46, Steven Rostedt wrote:
> In doing my tests last night before sending out my patch series this
> morning, I found that s390 build didn't work, but it wasn't due to my
> patches. I removed all my patches and built with latest mainline (which
> builds fine), and then merged the current tip/perf/core. The result
> didn't build.
> 
> I kicked off a ktest git bisect with last night's Linus tree as good,
> and with the merged in tip/perf/core as bad. It ended up with this patch
> that broke the build (which looks like a likely suspect).
> 
> 
> The break is this:
> 
>   LD      .tmp_vmlinux1
> arch/s390/oprofile/built-in.o: In function `oprofile_arch_exit':
> (.text+0x3f52): undefined reference to `oprofile_timer_exit'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2

A fix is already in tip/perf/core:

 f8c8520 oprofile: Fix oprofile_timer_exit() breakage

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

Re: oprofile patch broke s390 build in tip/perf/core

[Steven Rostedt]

On Wed, 2011-12-21 at 18:53 +0100, Robert Richter wrote:

> > The break is this:
> > 
> >   LD      .tmp_vmlinux1
> > arch/s390/oprofile/built-in.o: In function `oprofile_arch_exit':
> > (.text+0x3f52): undefined reference to `oprofile_timer_exit'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make: *** [sub-make] Error 2
> 
> A fix is already in tip/perf/core:
> 
>  f8c8520 oprofile: Fix oprofile_timer_exit() breakage

Huh, I thought I did a recent pull from tip. But it came in with my pull
today.


Thanks,

-- Steve