Re: [PATCH 2/5] s390: Virtual channel subsystem support.

Peter Maydell
2012-08-08T08:27:32Z

On 7 August 2012 15:52, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> +static void sch_handle_clear_func(SubchDev *sch)
> +{
> + struct pmcw *p = &sch->curr_status.pmcw;
> + struct scsw *s = &sch->curr_status.scsw;
> + int path;
> +
> + /* Path management: In our simple css, we always choose the only path. */
> + path = 0x80;
> +
> + /* Reset values prior to 'issueing the clear signal'. */
> + p->lpum = 0;

This is unnecessary since we're going to set p->lpum to something else about
ten lines later, right?

> + p->pom = 0xff;
> + s->pno = 0;
> +
> + /* We always 'attempt to issue the clear signal', and we always succeed. */
> + sch->orb = NULL;
> + sch->channel_prog = NULL;
> + sch->last_cmd = NULL;
> + s->actl &= ~SCSW_ACTL_CLEAR_PEND;
> + s->stctl |= SCSW_STCTL_STATUS_PEND;
> +
> + s->dstat = 0;
> + s->cstat = 0;
> + p->lpum = path;
> +
> +}

-- PMM