* Re: [PATCH] [S390] 3270 console: Drop unused spinlock
[not found] <20120906082156.GB4324@osiris.de.ibm.com>
@ 2012-09-06 8:26 ` Martin Schwidefsky
0 siblings, 0 replies; only message in thread
From: Martin Schwidefsky @ 2012-09-06 8:26 UTC (permalink / raw)
To: linux-s390
On Thu, 6 Sep 2012 09:55:56 +0200
Jean Delvare <khali@linux-fr.org> wrote:
> I was checking why this spinlock was never initialized, but it turns
> out it's not used anywhere, so we can drop it.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> I can't even build-test this.
>
> drivers/s390/char/con3270.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-3.6-rc4.orig/drivers/s390/char/con3270.c 2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.6-rc4/drivers/s390/char/con3270.c 2012-09-06 09:52:43.801881092 +0200
> @@ -35,7 +35,6 @@ static struct raw3270_fn con3270_fn;
> */
> struct con3270 {
> struct raw3270_view view;
> - spinlock_t lock;
> struct list_head freemem; /* list of free memory for strings. */
>
> /* Output stuff. */
>
>
That is true, the code always uses the view->lock. I'll add this to the queue. Thanks.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-09-06 8:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120906082156.GB4324@osiris.de.ibm.com>
2012-09-06 8:26 ` [PATCH] [S390] 3270 console: Drop unused spinlock Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).