linux-s390.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bugfix for kvm/s390.
@ 2013-01-15 10:17 Cornelia Huck
  2013-01-15 10:17 ` [PATCH] KVM: s390: kvm/sigp.c: fix memory leakage Cornelia Huck
  2013-01-17  6:42 ` [PATCH] Bugfix for kvm/s390 Gleb Natapov
  0 siblings, 2 replies; 3+ messages in thread
From: Cornelia Huck @ 2013-01-15 10:17 UTC (permalink / raw)
  To: Marcelo Tosatti, Gleb Natapov
  Cc: Christian Borntraeger, Carsten Otte, Alexander Graf,
	Heiko Carstens, Martin Schwidefsky, KVM, linux-s390

Hi,

here's another s390 bugfix for kvm-next. Please apply.

Cong Ding (1):
  KVM: s390: kvm/sigp.c: fix memory leakage

 arch/s390/kvm/sigp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
1.7.12.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] KVM: s390: kvm/sigp.c: fix memory leakage
  2013-01-15 10:17 [PATCH] Bugfix for kvm/s390 Cornelia Huck
@ 2013-01-15 10:17 ` Cornelia Huck
  2013-01-17  6:42 ` [PATCH] Bugfix for kvm/s390 Gleb Natapov
  1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2013-01-15 10:17 UTC (permalink / raw)
  To: Marcelo Tosatti, Gleb Natapov
  Cc: Christian Borntraeger, Carsten Otte, Alexander Graf,
	Heiko Carstens, Martin Schwidefsky, KVM, linux-s390, Cong Ding

From: Cong Ding <dinggnu@gmail.com>

the variable inti should be freed in the branch CPUSTAT_STOPPED.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 arch/s390/kvm/sigp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/s390/kvm/sigp.c b/arch/s390/kvm/sigp.c
index 461e841..1c48ab2 100644
--- a/arch/s390/kvm/sigp.c
+++ b/arch/s390/kvm/sigp.c
@@ -137,8 +137,10 @@ static int __inject_sigp_stop(struct kvm_s390_local_interrupt *li, int action)
 	inti->type = KVM_S390_SIGP_STOP;
 
 	spin_lock_bh(&li->lock);
-	if ((atomic_read(li->cpuflags) & CPUSTAT_STOPPED))
+	if ((atomic_read(li->cpuflags) & CPUSTAT_STOPPED)) {
+		kfree(inti);
 		goto out;
+	}
 	list_add_tail(&inti->list, &li->list);
 	atomic_set(&li->active, 1);
 	atomic_set_mask(CPUSTAT_STOP_INT, li->cpuflags);
-- 
1.7.12.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bugfix for kvm/s390.
  2013-01-15 10:17 [PATCH] Bugfix for kvm/s390 Cornelia Huck
  2013-01-15 10:17 ` [PATCH] KVM: s390: kvm/sigp.c: fix memory leakage Cornelia Huck
@ 2013-01-17  6:42 ` Gleb Natapov
  1 sibling, 0 replies; 3+ messages in thread
From: Gleb Natapov @ 2013-01-17  6:42 UTC (permalink / raw)
  To: Cornelia Huck
  Cc: Marcelo Tosatti, Christian Borntraeger, Carsten Otte,
	Alexander Graf, Heiko Carstens, Martin Schwidefsky, KVM,
	linux-s390

On Tue, Jan 15, 2013 at 11:17:28AM +0100, Cornelia Huck wrote:
> Hi,
> 
> here's another s390 bugfix for kvm-next. Please apply.
> 
Applied, thanks.

> Cong Ding (1):
>   KVM: s390: kvm/sigp.c: fix memory leakage
> 
>  arch/s390/kvm/sigp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> -- 
> 1.7.12.4

--
			Gleb.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-17  6:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-15 10:17 [PATCH] Bugfix for kvm/s390 Cornelia Huck
2013-01-15 10:17 ` [PATCH] KVM: s390: kvm/sigp.c: fix memory leakage Cornelia Huck
2013-01-17  6:42 ` [PATCH] Bugfix for kvm/s390 Gleb Natapov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).