From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, cornelia.huck@de.ibm.com,
mtosatti@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
linux-s390@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs
Date: Tue, 25 Jun 2013 08:48:32 +0200 [thread overview]
Message-ID: <20130625064832.GA4999@osiris> (raw)
In-Reply-To: <51C8F685.6000209@asianux.com>
On Tue, Jun 25, 2013 at 09:46:45AM +0800, Chen Gang wrote:
> When smp_add_present_cpu() fails, it has reset all things excluding
> 'c->hotpluggable', so need reset it as original state completely.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/s390/kernel/smp.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c
> index 15a016c..c4c6f42 100644
> --- a/arch/s390/kernel/smp.c
> +++ b/arch/s390/kernel/smp.c
> @@ -1016,6 +1016,7 @@ out_cpu:
> unregister_cpu(c);
> #endif
> out:
> + c->hotpluggable = 0;
> return rc;
No, that doesn't make sense. All cpus on s390 are always hotplugable.
It really doesn't matter if the value of this field is 0 or 1 after
an error.
next prev parent reply other threads:[~2013-06-25 6:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130625014645.qczOugAFBrMJO-5iGZyzyXFtqrHbXhehGoqqp8JU2eQ@z>
2013-06-25 1:46 ` [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Chen Gang
[not found] ` <20130625015441.yimPsU9P_MbLl68LALkInHU6BHTrHMbIdSo3M3RUxiM@z>
2013-06-25 1:54 ` [Suggestion] arch: s390: mm: the warnings with allmodconfig and "EXTRA_CFLAGS=-W" Chen Gang
[not found] ` <20130625065006.9nVf-cqdfTs0BrmaOdm4f8CQDGItep_9cSWKJDxCLyk@z>
2013-06-25 6:50 ` Martin Schwidefsky
2013-06-25 7:25 ` Chen Gang
2013-06-25 6:48 ` Heiko Carstens [this message]
2013-06-25 7:24 ` [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Chen Gang
2013-06-25 9:09 ` Heiko Carstens
2013-06-25 9:31 ` Chen Gang
2013-06-26 1:44 ` Chen Gang
2013-06-27 2:43 ` [PATCH v2] arch: s390: kernel: scan all present cpu forcely Chen Gang
2013-06-27 8:18 ` Heiko Carstens
2013-06-27 9:22 ` Chen Gang
2013-06-28 1:23 ` [PATCH] include/linux/interrupt.h: add dummy irq_set_irq_wake() for "!GENERIC_HARDIRQS" Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625064832.GA4999@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gang.chen@asianux.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mtosatti@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).