From: Tejun Heo <tj@kernel.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Subject: Re: [PATCH] s390/ccwgroup: Fix memory corruption
Date: Wed, 23 Apr 2014 15:01:08 -0400 [thread overview]
Message-ID: <20140423190108.GC4163@mtj.dyndns.org> (raw)
In-Reply-To: <1398279525-2837-1-git-send-email-borntraeger@de.ibm.com>
On Wed, Apr 23, 2014 at 08:58:45PM +0200, Christian Borntraeger wrote:
> commit 0b60f9ead5d4816e7e3d6e28f4a0d22d4a1b2513 (s390: use
> device_remove_file_self() instead of device_schedule_callback())
>
> caused random memory corruption on my s390 box. Turns out that the
> last element of the ccwgroup structure is of dynamic size, so we
> must move the newly introduced work structure _before_ the zero
> length array.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> CC: Tejun Heo <tj@kernel.org>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
> CC: Heiko Carstens <heiko.carstens@de.ibm.com>
> CC: Sebastian Ott <sebott@linux.vnet.ibm.com>
> CC: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Oops,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2014-04-23 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 18:58 [PATCH] s390/ccwgroup: Fix memory corruption Christian Borntraeger
2014-04-23 19:01 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423190108.GC4163@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=borntraeger@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).