* [PATCH] s390/ccwgroup: Fix memory corruption
@ 2014-04-23 18:58 Christian Borntraeger
2014-04-23 19:01 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Christian Borntraeger @ 2014-04-23 18:58 UTC (permalink / raw)
To: Martin Schwidefsky, Heiko Carstens
Cc: linux-s390, linux-kernel, Christian Borntraeger, Tejun Heo,
Greg Kroah-Hartman, Sebastian Ott, Peter Oberparleiter
commit 0b60f9ead5d4816e7e3d6e28f4a0d22d4a1b2513 (s390: use
device_remove_file_self() instead of device_schedule_callback())
caused random memory corruption on my s390 box. Turns out that the
last element of the ccwgroup structure is of dynamic size, so we
must move the newly introduced work structure _before_ the zero
length array.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
CC: Tejun Heo <tj@kernel.org>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
CC: Heiko Carstens <heiko.carstens@de.ibm.com>
CC: Sebastian Ott <sebott@linux.vnet.ibm.com>
CC: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
---
arch/s390/include/asm/ccwgroup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/include/asm/ccwgroup.h b/arch/s390/include/asm/ccwgroup.h
index 6e670f8..ebc2913 100644
--- a/arch/s390/include/asm/ccwgroup.h
+++ b/arch/s390/include/asm/ccwgroup.h
@@ -22,8 +22,8 @@ struct ccwgroup_device {
/* public: */
unsigned int count;
struct device dev;
- struct ccw_device *cdev[0];
struct work_struct ungroup_work;
+ struct ccw_device *cdev[0];
};
/**
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] s390/ccwgroup: Fix memory corruption
2014-04-23 18:58 [PATCH] s390/ccwgroup: Fix memory corruption Christian Borntraeger
@ 2014-04-23 19:01 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-04-23 19:01 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Martin Schwidefsky, Heiko Carstens, linux-s390, linux-kernel,
Greg Kroah-Hartman, Sebastian Ott, Peter Oberparleiter
On Wed, Apr 23, 2014 at 08:58:45PM +0200, Christian Borntraeger wrote:
> commit 0b60f9ead5d4816e7e3d6e28f4a0d22d4a1b2513 (s390: use
> device_remove_file_self() instead of device_schedule_callback())
>
> caused random memory corruption on my s390 box. Turns out that the
> last element of the ccwgroup structure is of dynamic size, so we
> must move the newly introduced work structure _before_ the zero
> length array.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> CC: Tejun Heo <tj@kernel.org>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
> CC: Heiko Carstens <heiko.carstens@de.ibm.com>
> CC: Sebastian Ott <sebott@linux.vnet.ibm.com>
> CC: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Oops,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-23 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-23 18:58 [PATCH] s390/ccwgroup: Fix memory corruption Christian Borntraeger
2014-04-23 19:01 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).