* [PATCH] s390/hmcdrv: Restrict s390 HMC driver to S390 arch
@ 2014-10-14 14:13 Josh Boyer
2014-10-14 15:03 ` Martin Schwidefsky
0 siblings, 1 reply; 2+ messages in thread
From: Josh Boyer @ 2014-10-14 14:13 UTC (permalink / raw)
To: Martin Schwidefsky; +Cc: Heiko Carstens, Ralf Hoppe, linux-s390, linux-kernel
This driver is only usable on 64-bit s390 machines. Mark the Kconfig
dependencies to that users on other architectures are not prompted for it.
Fixes: 8f933b1043e1e5 ("s390/hmcdrv: HMC drive CD/DVD access")
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
drivers/s390/char/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
index dc24ecfac2d1..db2cb1f8a1b5 100644
--- a/drivers/s390/char/Kconfig
+++ b/drivers/s390/char/Kconfig
@@ -105,7 +105,7 @@ config SCLP_ASYNC
config HMC_DRV
def_tristate m
prompt "Support for file transfers from HMC drive CD/DVD-ROM"
- depends on 64BIT
+ depends on S390 && 64BIT
select CRC16
help
This option enables support for file transfers from a Hardware
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/hmcdrv: Restrict s390 HMC driver to S390 arch
2014-10-14 14:13 [PATCH] s390/hmcdrv: Restrict s390 HMC driver to S390 arch Josh Boyer
@ 2014-10-14 15:03 ` Martin Schwidefsky
0 siblings, 0 replies; 2+ messages in thread
From: Martin Schwidefsky @ 2014-10-14 15:03 UTC (permalink / raw)
To: Josh Boyer; +Cc: Heiko Carstens, Ralf Hoppe, linux-s390, linux-kernel
On Tue, 14 Oct 2014 10:13:42 -0400
Josh Boyer <jwboyer@fedoraproject.org> wrote:
> This driver is only usable on 64-bit s390 machines. Mark the Kconfig
> dependencies to that users on other architectures are not prompted for it.
>
> Fixes: 8f933b1043e1e5 ("s390/hmcdrv: HMC drive CD/DVD access")
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
> drivers/s390/char/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
> index dc24ecfac2d1..db2cb1f8a1b5 100644
> --- a/drivers/s390/char/Kconfig
> +++ b/drivers/s390/char/Kconfig
> @@ -105,7 +105,7 @@ config SCLP_ASYNC
> config HMC_DRV
> def_tristate m
> prompt "Support for file transfers from HMC drive CD/DVD-ROM"
> - depends on 64BIT
> + depends on S390 && 64BIT
> select CRC16
> help
> This option enables support for file transfers from a Hardware
Indeed. I'll queue this patch to the fixes branch of the s390 tree.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-14 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-14 14:13 [PATCH] s390/hmcdrv: Restrict s390 HMC driver to S390 arch Josh Boyer
2014-10-14 15:03 ` Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).