From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 28 Nov 2014 09:52:26 +0100 From: David Hildenbrand Subject: Re: [PATCH v6 04/46] virtio: add support for 64 bit features. Message-ID: <20141128095226.44781a98@thinkpad-w530> In-Reply-To: <1417118789-18231-5-git-send-email-mst@redhat.com> References: <1417118789-18231-1-git-send-email-mst@redhat.com> <1417118789-18231-5-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, David Miller , cornelia.huck@de.ibm.com, rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, thuth@linux.vnet.ibm.com, Rusty Russell , Ohad Ben-Cohen , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Greg Kroah-Hartman , Siva Yerramreddy , Joel Stanley , lguest@lists.ozlabs.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org List-ID: > Change u32 to u64, and use BIT_ULL and 1ULL everywhere. > > Note: transports are unchanged, and only set low 32 bit. > This guarantees that no transport sets e.g. VERSION_1 > by mistake without proper support. > > Based on patch by Rusty. > > Signed-off-by: Rusty Russell > Signed-off-by: Cornelia Huck > Signed-off-by: Michael S. Tsirkin > --- Reviewed-by: David Hildenbrand