From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 28 Nov 2014 09:54:36 +0100 From: David Hildenbrand Subject: Re: [PATCH v6 05/46] virtio: assert 32 bit features in transports Message-ID: <20141128095436.20c59e84@thinkpad-w530> In-Reply-To: <1417118789-18231-6-git-send-email-mst@redhat.com> References: <1417118789-18231-1-git-send-email-mst@redhat.com> <1417118789-18231-6-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, David Miller , cornelia.huck@de.ibm.com, rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, thuth@linux.vnet.ibm.com, Rusty Russell , Ohad Ben-Cohen , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Sudeep Dutt , Siva Yerramreddy , lguest@lists.ozlabs.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org List-ID: > At this point, no transports set any of the high 32 feature bits. > Since transports generally can't (yet) cope with such bits, add BUG_ON > checks to make sure they are not set by mistake. > > Based on rproc patch by Rusty. > > Signed-off-by: Rusty Russell > Signed-off-by: Michael S. Tsirkin > --- > drivers/lguest/lguest_device.c | 3 +++ > drivers/misc/mic/card/mic_virtio.c | 3 +++ > drivers/remoteproc/remoteproc_virtio.c | 3 +++ > drivers/s390/kvm/kvm_virtio.c | 3 +++ > drivers/s390/kvm/virtio_ccw.c | 3 +++ > drivers/virtio/virtio_mmio.c | 3 +++ > drivers/virtio/virtio_pci.c | 3 +++ > 7 files changed, 21 insertions(+) > Looks sane to me. Reviewed-by: David Hildenbrand