From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 28 Nov 2014 13:44:57 +0100 From: Cornelia Huck Subject: Re: [PATCH v6 02/46] virtio: use u32, not bitmap for features Message-ID: <20141128134457.37e427ce.cornelia.huck@de.ibm.com> In-Reply-To: <1417118789-18231-3-git-send-email-mst@redhat.com> References: <1417118789-18231-1-git-send-email-mst@redhat.com> <1417118789-18231-3-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, David Miller , rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, thuth@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, Rusty Russell , Arnd Bergmann , Greg Kroah-Hartman , Amit Shah , Ohad Ben-Cohen , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Ashutosh Dixit , Nikhil Rao , Siva Yerramreddy , Joel Stanley , virtualization@lists.linux-foundation.org, lguest@lists.ozlabs.org, linux-s390@vger.kernel.org List-ID: On Thu, 27 Nov 2014 22:07:41 +0200 "Michael S. Tsirkin" wrote: > It seemed like a good idea to use bitmap for features > in struct virtio_device, but it's actually a pain, > and seems to become even more painful when we get more > than 32 feature bits. Just change it to a u32 for now. > > Based on patch by Rusty. > > Suggested-by: David Hildenbrand > Signed-off-by: Rusty Russell > Signed-off-by: Cornelia Huck > Signed-off-by: Michael S. Tsirkin > diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c > index d34ebfa..ab95a4c 100644 > --- a/drivers/virtio/virtio_pci.c > +++ b/drivers/virtio/virtio_pci.c > @@ -120,8 +120,7 @@ static void vp_finalize_features(struct virtio_device *vdev) > vring_transport_features(vdev); > > /* We only support 32 feature bits. */ I think you can kill this comment... > - BUILD_BUG_ON(ARRAY_SIZE(vdev->features) != 1); > - iowrite32(vdev->features[0], vp_dev->ioaddr+VIRTIO_PCI_GUEST_FEATURES); > + iowrite32(vdev->features, vp_dev->ioaddr+VIRTIO_PCI_GUEST_FEATURES); ...and add blanks around '+', as you're touching this line anyway. > } > > /* virtio config->get() implementation */ Reviewed-by: Cornelia Huck