From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 28 Nov 2014 13:47:21 +0100 From: Cornelia Huck Subject: Re: [PATCH v6 04/46] virtio: add support for 64 bit features. Message-ID: <20141128134721.5473ebbd.cornelia.huck@de.ibm.com> In-Reply-To: <1417118789-18231-5-git-send-email-mst@redhat.com> References: <1417118789-18231-1-git-send-email-mst@redhat.com> <1417118789-18231-5-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, David Miller , rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com, thuth@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, Rusty Russell , Ohad Ben-Cohen , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Greg Kroah-Hartman , Siva Yerramreddy , Joel Stanley , lguest@lists.ozlabs.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org List-ID: On Thu, 27 Nov 2014 22:07:55 +0200 "Michael S. Tsirkin" wrote: > Change u32 to u64, and use BIT_ULL and 1ULL everywhere. > > Note: transports are unchanged, and only set low 32 bit. > This guarantees that no transport sets e.g. VERSION_1 > by mistake without proper support. > > Based on patch by Rusty. > > Signed-off-by: Rusty Russell > Signed-off-by: Cornelia Huck > Signed-off-by: Michael S. Tsirkin > --- > include/linux/virtio.h | 2 +- > include/linux/virtio_config.h | 20 ++++++++++---------- > tools/virtio/linux/virtio.h | 2 +- > drivers/lguest/lguest_device.c | 2 +- > drivers/misc/mic/card/mic_virtio.c | 2 +- > drivers/remoteproc/remoteproc_virtio.c | 2 +- > drivers/s390/kvm/kvm_virtio.c | 2 +- > drivers/s390/kvm/virtio_ccw.c | 2 +- > drivers/virtio/virtio.c | 8 ++++---- > drivers/virtio/virtio_mmio.c | 2 +- > drivers/virtio/virtio_pci.c | 2 +- > 11 files changed, 23 insertions(+), 23 deletions(-) Reviewed-by: Cornelia Huck