Re: [GIT PULL 05/11] KVM: s390: refactor interrupt injection code

Christian Borntraeger
2014-12-01T08:00:28Z

Am 28.11.2014 um 18:16 schrieb Paolo Bonzini:
>
>
> On 28/11/2014 14:25, Christian Borntraeger wrote:
>>
>> +static int __inject_prog_irq(struct kvm_vcpu *vcpu,
>> + struct kvm_s390_interrupt_info *inti)
>> +{
>
> Why the __s? :)

In this case because its called with a lock already held. (from kvm_s390_inject_vcpu).
I usually extend the usage of the __ prefix to "heho, pay attention. YOu are calling this function, but you are maybe supposed to do something else).

Christian