From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 10 Dec 2014 09:41:39 +0100 From: Cornelia Huck Subject: Re: [PATCH v3 4/6] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 Message-ID: <20141210094139.7f2e2d01.cornelia.huck@de.ibm.com> In-Reply-To: <20141209194052.GA21095@redhat.com> References: <1418042769-25539-1-git-send-email-mst@redhat.com> <1418042769-25539-5-git-send-email-mst@redhat.com> <20141209120123.117ccfac.cornelia.huck@de.ibm.com> <20141209122118.GF3993@redhat.com> <20141209182319.20ce2dec.cornelia.huck@de.ibm.com> <20141209194052.GA21095@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, dahi@linux.vnet.ibm.com, rusty@rustcorp.com.au, Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org List-ID: On Tue, 9 Dec 2014 21:40:52 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 09, 2014 at 06:23:19PM +0100, Cornelia Huck wrote: > > On Tue, 9 Dec 2014 14:21:18 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 09, 2014 at 12:01:23PM +0100, Cornelia Huck wrote: > > > > On Mon, 8 Dec 2014 15:06:03 +0200 > > > > "Michael S. Tsirkin" wrote: > > > > > > > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c > > > > > index 789275f..f9f87ba 100644 > > > > > --- a/drivers/s390/kvm/virtio_ccw.c > > > > > +++ b/drivers/s390/kvm/virtio_ccw.c > > > > > @@ -758,6 +758,13 @@ static int virtio_ccw_finalize_features(struct virtio_device *vdev) > > > > > struct virtio_feature_desc *features; > > > > > struct ccw1 *ccw; > > > > This needs > > > > + struct virtio_device *vdev = &vcdev->vdev; > > > > to make it compile :) > > In fact why does it? > vdev is a parameter. Never mind, messed up tree on my side.