Re: [PATCH] s390: boot: compressed: misc: Express the return value of _sclp_print_early()

Chen Gang S
2015-01-05T09:37:50Z

On 1/5/15 17:21, Heiko Carstens wrote:
> On Sat, Jan 03, 2015 at 05:29:07PM +0800, Chen Gang wrote:
>> _sclp_print_early() has return value: at present, return 0 for OK, 1 for
>> failure. It returns '%r2', so use 'long' as return value (upper caller
>> can check '%r2' directly). The related warning:
>>
>> CC arch/s390/boot/compressed/misc.o
>> arch/s390/boot/compressed/misc.c:66:8: warning: type defaults to 'int' in declaration of '_sclp_print_early' [-Wimplicit-int]
>> extern _sclp_print_early(const char *);
>> ^
>>
>> At present, _sclp_print_early() is only used by puts(), so can still
>> remain its declaration in 'misc.c' file.
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> arch/s390/boot/compressed/misc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/boot/compressed/misc.c b/arch/s390/boot/compressed/misc.c
>> index 57cbaff..09003b2 100644
>> --- a/arch/s390/boot/compressed/misc.c
>> +++ b/arch/s390/boot/compressed/misc.c
>> @@ -63,7 +63,7 @@ static unsigned long free_mem_end_ptr;
>> #include "../../../../lib/decompress_unxz.c"
>> #endif
>>
>> -extern _sclp_print_early(const char *);
>> +extern long _sclp_print_early(const char *);
>
> Thanks, applied. However I moved the declaration to the sclp header file.
>

OK, Thanks.

--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed