* [PATCH 0/4] add NULL test
@ 2015-12-20 11:15 Julia Lawall
2015-12-20 11:15 ` [PATCH 3/4] s390/cio: " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2015-12-20 11:15 UTC (permalink / raw)
To: linux-s390
Cc: kernel-janitors, linuxppc-dev, alsa-devel, linux-kernel,
linux-omap
Add NULL tests on various calls to kzalloc and devm_kzalloc.
The semantic match that finds these problems is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,y;
identifier fld;
@@
(
x = \(vmalloc\|kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|krealloc\|
kmemdup\|kstrdup\|
devm_kzalloc\|devm_kmalloc\|devm_kcalloc\|devm_kasprintf\|
kmalloc_array\)(...,<+... __GFP_NOFAIL ...+>,...);
|
* x = \(vmalloc\|kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|krealloc\|
kmemdup\|kstrdup\|
devm_kzalloc\|devm_kmalloc\|devm_kcalloc\|devm_kasprintf\|
kmalloc_array\)(...);
)
... when != (x) == NULL
when != (x) != NULL
when != (x) == 0
when != (x) != 0
when != x = y
(
x->fld
|
*x
|
x[...]
)
// </smpl>
---
drivers/s390/char/con3215.c | 2 ++
drivers/s390/char/raw3270.c | 2 ++
sound/soc/fsl/imx-pcm-dma.c | 2 ++
sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 ++
sound/soc/omap/omap-hdmi-audio.c | 2 ++
5 files changed, 10 insertions(+)
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 3/4] s390/cio: add NULL test 2015-12-20 11:15 [PATCH 0/4] add NULL test Julia Lawall @ 2015-12-20 11:15 ` Julia Lawall 2015-12-21 9:33 ` Heiko Carstens 0 siblings, 1 reply; 3+ messages in thread From: Julia Lawall @ 2015-12-20 11:15 UTC (permalink / raw) To: Martin Schwidefsky Cc: kernel-janitors, Heiko Carstens, linux-s390, linux-kernel Add NULL test on call to kzalloc. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x; identifier fld; @@ * x = kzalloc(...); ... when != x == NULL x->fld // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/s390/char/con3215.c | 2 ++ 1 files changed, 2 insertions(+) diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c index 0fc3fe5..7d82bbc 100644 --- a/drivers/s390/char/con3215.c +++ b/drivers/s390/char/con3215.c @@ -922,6 +922,8 @@ static int __init con3215_init(void) spin_lock_init(&raw3215_freelist_lock); for (i = 0; i < NR_3215_REQ; i++) { req = kzalloc(sizeof(struct raw3215_req), GFP_KERNEL | GFP_DMA); + if (!req) + return -ENOMEM; req->next = raw3215_freelist; raw3215_freelist = req; } ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] s390/cio: add NULL test 2015-12-20 11:15 ` [PATCH 3/4] s390/cio: " Julia Lawall @ 2015-12-21 9:33 ` Heiko Carstens 0 siblings, 0 replies; 3+ messages in thread From: Heiko Carstens @ 2015-12-21 9:33 UTC (permalink / raw) To: Julia Lawall Cc: Martin Schwidefsky, kernel-janitors, linux-s390, linux-kernel On Sun, Dec 20, 2015 at 12:15:52PM +0100, Julia Lawall wrote: > Add NULL test on call to kzalloc. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression x; > identifier fld; > @@ > > * x = kzalloc(...); > ... when != x == NULL > x->fld > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Aplied, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-21 9:33 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-12-20 11:15 [PATCH 0/4] add NULL test Julia Lawall 2015-12-20 11:15 ` [PATCH 3/4] s390/cio: " Julia Lawall 2015-12-21 9:33 ` Heiko Carstens
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).