From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
arnd@arndb.de, linux-doc@vger.kernel.org,
Prasun.Kapoor@caviumnetworks.com, catalin.marinas@arm.com,
pinskia@gmail.com, Nathan_Lynch@mentor.com,
linux-kernel@vger.kernel.org, agraf@suse.de,
klimov.linux@gmail.com, broonie@kernel.org,
bamvor.zhangjian@huawei.com, joseph@codesourcery.com,
linux-arm-kernel@lists.infradead.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it for s390
Date: Thu, 25 Feb 2016 23:10:18 +0100 [thread overview]
Message-ID: <20160225221018.GA5950@osiris> (raw)
In-Reply-To: <20160225201926.GA16123@yury-N73SV>
On Thu, Feb 25, 2016 at 11:19:26PM +0300, Yury Norov wrote:
> On Thu, Feb 25, 2016 at 09:49:43AM +0100, Heiko Carstens wrote:
> > On Wed, Feb 24, 2016 at 09:34:11PM +0300, Yury Norov wrote:
> > > Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> > > ---
> > > arch/Kconfig | 4 ++++
> > > arch/s390/Kconfig | 1 +
> > > 2 files changed, 5 insertions(+)
> > >
> > > diff --git a/arch/Kconfig b/arch/Kconfig
> > > index f6b649d..6393093 100644
> > > --- a/arch/Kconfig
> > > +++ b/arch/Kconfig
> > > @@ -583,6 +583,10 @@ config HAVE_COPY_THREAD_TLS
> > > normal C parameter passing, rather than extracting the syscall
> > > argument from pt_regs.
> > >
> > > +config COMPAT_WRAPPER
> > > + bool
> > > + depends on COMPAT
> > > +
> > > #
> > > # ABI hall of shame
> > > #
> > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > > index 3be9c83..082b861 100644
> > > --- a/arch/s390/Kconfig
> > > +++ b/arch/s390/Kconfig
> > > @@ -333,6 +333,7 @@ config COMPAT
> > > select COMPAT_BINFMT_ELF if BINFMT_ELF
> > > select ARCH_WANT_OLD_COMPAT_IPC
> > > select COMPAT_OLD_SIGACTION
> > > + select COMPAT_WRAPPER
> > > depends on MULTIUSER
> > > help
> > > Select this option if you want to enable your system kernel to
> >
> > Maybe merge this into patch 4/5?
>
> Then bisectability will suffer, as next patch needs COMPAT_WRAPPER
> enabled.
Oh, right. I didn't realize that you put the macros between an
#ifdef CONFIG_COMPAT_WRAPPER . It's not strictly needed, but it
doesn't hurt as well.
next prev parent reply other threads:[~2016-02-25 22:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160224183409.Z0-V7M-5gyw9GvgM_xLdQ4umDDai2oMiIv0Fk768GR0@z>
2016-02-24 18:34 ` [PATCH v2 0/5] all: s390: make compat wrappers the generic solution Yury Norov
[not found] ` <20160224183410.akd29iMQICIHfxlkQmUrbv0BbkwUnSqllVoo9539Uuk@z>
2016-02-24 18:34 ` [PATCH 1/5] all: syscall wrappers: add documentation Yury Norov
[not found] ` <20160224183411.3BagGddeYJJBc0v0u-1Amx1u8W5aIsKQqzjrVHzAZ30@z>
2016-02-24 18:34 ` [PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it for s390 Yury Norov
[not found] ` <20160225084943.ZpfrJ6W7U0h855DYm2O7Wqn3rOAZwwACqQUBXZBdaoc@z>
2016-02-25 8:49 ` Heiko Carstens
2016-02-25 20:19 ` Yury Norov
2016-02-25 22:10 ` Heiko Carstens [this message]
[not found] ` <20160224183412.8YANxpFDCCnUfsfbTyfVXmUywYsL-3sq10q8dIhjVLM@z>
2016-02-24 18:34 ` [PATCH 3/5] all: s390: move wrapper infrastructure to generic headers Yury Norov
[not found] ` <20160225085140.8i-qLUab7G-KDu0pTBy3oCwiFU7xqNgQRmijv5rIg2c@z>
2016-02-25 8:51 ` Heiko Carstens
2016-02-25 20:23 ` Yury Norov
2016-02-25 22:20 ` Heiko Carstens
[not found] ` <20160224183413.dgt96jcRrtBwBfE3KGH7yCzl1FewRaNvzzNuYnSEILI@z>
2016-02-24 18:34 ` [PATCH 4/5] all: s390: move compat_wrappers.c from arch/s390/kernel to kernel/ Yury Norov
[not found] ` <20160225085227.nsamepb6Yl6XvLsVRtltlvyh2pXR9iPWoSA4bcom5aw@z>
2016-02-25 8:52 ` Heiko Carstens
2016-02-25 20:27 ` Yury Norov
[not found] ` <20160224183414.3tsYWbZu2fuiiwTl6lB_d0tMCpwgBsFNJb7IFy7LECo@z>
2016-02-24 18:34 ` [PATCH 5/5] all: wrap needed syscalls in generic unistd Yury Norov
2016-02-25 8:54 ` [PATCH v2 0/5] all: s390: make compat wrappers the generic solution Heiko Carstens
2016-02-26 14:34 [PATCH v3 " Yury Norov
2016-02-26 14:34 ` [PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it for s390 Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225221018.GA5950@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=Nathan_Lynch@mentor.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bamvor.zhangjian@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=joseph@codesourcery.com \
--cc=klimov.linux@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pinskia@gmail.com \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).