[PATCH] s390: fix build failure

[PATCH] s390: fix build failure

[Sudip Mukherjee]

s390 defconfig fails with the error:
ERROR: "phys_to_pfn_t" [drivers/s390/block/dcssblk.ko] undefined!

We need CONFIG_HAS_IOMEM for phys_to_pfn_t() and for that we need to
have CONFIG_PCI.

Fixes: bfac97e7b361 ("mm, dax, pmem: introduce pfn_t")
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

s390 defconfig with next-20151222 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/98258271

 arch/s390/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/s390/defconfig b/arch/s390/defconfig
index 9256b48..e56b6df 100644
--- a/arch/s390/defconfig
+++ b/arch/s390/defconfig
@@ -207,3 +207,4 @@ CONFIG_CRC7=m
 # CONFIG_XZ_DEC_ARMTHUMB is not set
 # CONFIG_XZ_DEC_SPARC is not set
 CONFIG_CMM=m
+CONFIG_PCI=y
-- 
1.9.1

Re: [PATCH] s390: fix build failure

[Dan Williams]

On Mon, Dec 21, 2015 at 10:40 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> s390 defconfig fails with the error:
> ERROR: "phys_to_pfn_t" [drivers/s390/block/dcssblk.ko] undefined!
>
> We need CONFIG_HAS_IOMEM for phys_to_pfn_t() and for that we need to
> have CONFIG_PCI.
>
> Fixes: bfac97e7b361 ("mm, dax, pmem: introduce pfn_t")
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---

Hi, I fixed this build breakage in v4 of the patch series that
introduces phys_to_pfn_t() [1].  Chnaging the config is not correct
the HAS_IOMEM dependency for the symbol needs to be satisfied.

[1]: https://lists.01.org/pipermail/linux-nvdimm/2015-December/003610.html

[PATCH] s390: fix build failure

[Sudip Mukherjee]

s390 defconfig and allmodconfig fails with the error:
kernel/seccomp.c: In function '__secure_computing_strict':
kernel/seccomp.c:526:3: error: implicit declaration of function
				'get_compat_mode1_syscalls'

The retrieval of compat syscall numbers were moved into inline function
defined in asm-generic header but the asm-generic header was not being
used by s390.

Fixes: 5adddb612ca1 ("seccomp: Get compat syscalls from asm-generic header")
Cc: Matt Redfearn <matt.redfearn@imgtec.com>
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

Tested with s390 defconfig and allmodconfig build.
Build logs of next-20160401 are at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983952 (allmodconfig)
and
https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983909 (defconfig)

 arch/s390/include/asm/seccomp.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/s390/include/asm/seccomp.h b/arch/s390/include/asm/seccomp.h
index 781a9cf..e10f833 100644
--- a/arch/s390/include/asm/seccomp.h
+++ b/arch/s390/include/asm/seccomp.h
@@ -13,4 +13,6 @@
 #define __NR_seccomp_exit_32	__NR_exit
 #define __NR_seccomp_sigreturn_32 __NR_sigreturn
 
+#include <asm-generic/seccomp.h>
+
 #endif	/* _ASM_S390_SECCOMP_H */
-- 
2.1.4

Re: [PATCH] s390: fix build failure

[Heiko Carstens]

On Fri, Apr 01, 2016 at 01:35:16PM +0100, Sudip Mukherjee wrote:
> s390 defconfig and allmodconfig fails with the error:
> kernel/seccomp.c: In function '__secure_computing_strict':
> kernel/seccomp.c:526:3: error: implicit declaration of function
> 				'get_compat_mode1_syscalls'
> 
> The retrieval of compat syscall numbers were moved into inline function
> defined in asm-generic header but the asm-generic header was not being
> used by s390.
> 
> Fixes: 5adddb612ca1 ("seccomp: Get compat syscalls from asm-generic header")
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> 
> Tested with s390 defconfig and allmodconfig build.
> Build logs of next-20160401 are at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983952 (allmodconfig)
> and
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983909 (defconfig)
> 
>  arch/s390/include/asm/seccomp.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/s390/include/asm/seccomp.h b/arch/s390/include/asm/seccomp.h
> index 781a9cf..e10f833 100644
> --- a/arch/s390/include/asm/seccomp.h
> +++ b/arch/s390/include/asm/seccomp.h
> @@ -13,4 +13,6 @@
>  #define __NR_seccomp_exit_32	__NR_exit
>  #define __NR_seccomp_sigreturn_32 __NR_sigreturn
> 
> +#include <asm-generic/seccomp.h>
> +
>  #endif	/* _ASM_S390_SECCOMP_H */

Applied with a modified changelog, since it makes sense anyway to include
the generic header file.