Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable

Ingo Molnar
2016-04-13T09:19:43Z

* Michal Hocko <mhocko@kernel.org> wrote:

> On Wed 13-04-16 11:08:30, Ingo Molnar wrote:
> >
> > * Michal Hocko <mhocko@kernel.org> wrote:
> [...]
> > > +ENTRY(call_rwsem_down_write_failed_killable)
> > > + save_common_regs
> > > + movq %rax,%rdi
> > > + call rwsem_down_write_failed_killable
> > > + restore_common_regs
> > > + ret
> > > +ENDPROC(call_rwsem_down_write_failed_killable)
> >
> > Got this objtool warning on x86-64 allyesconfig:
> >
> > arch/x86/lib/rwsem.o: warning: objtool: call_rwsem_down_write_failed_killable()+0xe: call without frame pointer save/setup
>
> Peter has already pointed that out. This is because the 4.5 which I was
> basing my work on doesn't have 3387a535ce62 ("x86/asm: Create stack
> frames in rwsem functions") which shown up in 4.6-rc1. He mentioned to
> add the missing FRAME_{BEGIN,END} during the merge AFAIR.
>
> Does that sound reasonable to you or should I rebase?

I'm testing your patches today, if they are otherwise OK then please send a delta
patch against the tip:locking/rwsem tree I'll push out.

Thanks,

Ingo